Documented the "autoescape" TwigBundle config option #6539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would add a note saying that disabling the autoescaping globally could open XSS holes as all bundles in the ecosystem rely on auto-escaping rather than explicitly escaping everything. So using |
|
@stof thanks for your insightful comment. That's definitely something we need to mention. I've updated the PR. Thanks! |
| **type**: ``boolean`` or ``string`` **default**: ``'filename'`` | ||
|
|
||
| If set to ``true``, all template contents are escaped for HTML. If set to | ||
| ``false``, no escaping is applied automatically (you can still escape each |
There was a problem hiding this comment.
"If set to false, automatic escaping is disabled (you can still [...]" ?
|
@wouterj thanks for the review. I've fixed everything. |
|
👍 |
wouterj
added a commit
that referenced
this pull request
May 13, 2016
|
Thanks @javiereguiluz! It looks great. I've made some very minor changes in c7e2145 |
xabbuh
added a commit
that referenced
this pull request
May 14, 2016
* 2.3: Remove extra spaces in Nginx template [#6539] Some small improvements Documented the "autoescape" TwigBundle config option fixing special shortcut syntax Editing the Doctrine section to improve accuracy and readability Improved "optional argument" documentation"
xabbuh
added a commit
that referenced
this pull request
May 14, 2016
* 2.7: [#6566] fix indentation Update options_resolver.rst Fixing a typo - thanks to @tacman Remove extra spaces in Nginx template [#6539] Some small improvements Documented the "autoescape" TwigBundle config option fixing special shortcut syntax Editing the Doctrine section to improve accuracy and readability Improved "optional argument" documentation"
xabbuh
added a commit
that referenced
this pull request
May 14, 2016
* 2.8: [#6566] fix indentation Update options_resolver.rst Fixing a typo - thanks to @tacman Fix build [#6564] Revert doc removal in 2.8 Replace property_accessor by property_access Remove extra spaces in Nginx template [#6539] Some small improvements Documented the "autoescape" TwigBundle config option [PhpUnitBridge] Add versionadded directive to clock mocking section [PhpUnitBridge] Remove section about clock mocking fixing special shortcut syntax Add missed link to the external PSR-4 specification. Editing the Doctrine section to improve accuracy and readability Typo fix in the Serializer deserialization example drop AppBundle examples in components section Make ClockMock Tests\\ namespace matching less specific Improved "optional argument" documentation"
xabbuh
added a commit
that referenced
this pull request
May 14, 2016
* 3.0: [#6566] fix indentation Update options_resolver.rst Fixing a typo - thanks to @tacman Fix build [#6564] Revert doc removal in 2.8 Replace property_accessor by property_access Remove extra spaces in Nginx template [#6539] Some small improvements Documented the "autoescape" TwigBundle config option [PhpUnitBridge] Add versionadded directive to clock mocking section [PhpUnitBridge] Remove section about clock mocking fixing special shortcut syntax Add missed link to the external PSR-4 specification. Editing the Doctrine section to improve accuracy and readability Typo fix in the Serializer deserialization example drop AppBundle examples in components section merge choice_translation_domain files remove 2.x versionadded directives Make ClockMock Tests\\ namespace matching less specific Improved "optional argument" documentation"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option was missing after the recent doc update.