[best practices] mostly typos #6348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
talitakz
commented
Mar 11, 2016
talitakz
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | x |
|
I made a mistake!! I request merge into 2.3! I apologize. |
|
@paxyknox no worries! Selecting the wrong branch is something that happen to all of us sometimes 😞 Thanks for fixing all these typos and thanks for contributing a small pull request, which makes it much easier to review. Thanks! |
| @@ -80,7 +80,7 @@ The ``@Template`` annotation is useful, but also involves some magic. We | |||
| don't think its benefit is worth the magic, and so recommend against using | |||
| it. | |||
|
|
|||
| Most of the time, ``@Template`` is used without any parameters, which makes | |||
| Most of the time, ``@Template()`` is used without any parameters, which makes | |||
There was a problem hiding this comment.
As I explained in another great PR of you, I don't like using () for annotations.
|
I made requested changes. |
xabbuh
added a commit
that referenced
this pull request
Mar 11, 2016
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #6348). Discussion ---------- [best practices] mostly typos | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | x Commits ------- 68e3184 [best practices] mostly typos
xabbuh
added a commit
that referenced
this pull request
Mar 11, 2016
|
Thank you @paxyknox. Very nice changes again! 👍 I have merged them into the |
xabbuh
added a commit
that referenced
this pull request
Mar 11, 2016
* 2.3: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings
xabbuh
added a commit
that referenced
this pull request
Mar 11, 2016
* 2.7: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings Rename DunglasApiBundle to ApiPlatform
xabbuh
added a commit
that referenced
this pull request
Mar 11, 2016
* 2.8: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings Rename DunglasApiBundle to ApiPlatform
xabbuh
added a commit
that referenced
this pull request
Mar 11, 2016
* 3.0: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos Fix reference to app folder [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings Rename DunglasApiBundle to ApiPlatform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.