[reference] [form] [options] fix #6153 #6156
Conversation
HeahDude
commented
Jan 16, 2016
HeahDude
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3+ |
| Fixed tickets | #6153 |
| * The right side contains simply the names of fields in the form. | ||
|
|
||
| Additionally, you can set the left side to dot ``.`` which refers to any |
There was a problem hiding this comment.
I would change "[...] to dot . which refers [...]" to "[...] to dot (.), which refers [...]"
|
Hi @HeahDude. I've left some comments on your PR, you can fix these by adding other commits to the branch of this PR. After the comments are fixed, this PR is ready to merge imo. |
|
Thank you @wouterj for the review, comments addressed in last commit |
|
👍 Thanks for the quick response! |
| * The right side contains simply the names of fields in the form. | ||
|
|
||
| Additionally, you can set the left side to dot (``.``), which refers to any | ||
| unmapped properties or methods needing validation to the given nested field instead |
|
ping @xabbuh |
|
|
||
| Additionally, you can set the left side to dot (``.``), which refers to any | ||
| unmapped property or method needing validation to the given nested field instead | ||
| of bubbling them to the form:: |
There was a problem hiding this comment.
Actually, I still find this sentence confusing and suggest to change it to something like this:
By default, errors for any property that is not mapped will bubble up to the parent form. You can use the dot (
.) on the left side to map errors of all unmapped properties to a particular field.
What do you think?
There was a problem hiding this comment.
@wouterj, thanks for merging this. I agree with @xabbuh for the rephrasing except for "parent form" and "a particular field" because it's not obvious that (.) symbolise the current FormType being configured with defaultOptions()|configureOptions(). It should be respectively "current FormType" and "one of its children" instead IMHO.
This PR was squashed before being merged into the 2.3 branch (closes #6156). Discussion ---------- [reference] [form] [options] fix #6153 | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | #6153 Commits ------- a15f856 [reference] [form] [options] fix #6153
