Fix words according context #5989
Conversation
richardpq
commented
Dec 8, 2015
richardpq
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3+ |
| Fixed tickets | n/a |
According to the context the correct word to use is "formatters" instead of "filters".
In this context the correct phrase is "On the other hand" instead of "In the other hand", so just replace "I" by "O".
|
After submit this PR, I noticed that this should applied to 2.3+ (I made the PR to 2.8), should I close this and submit a new PR from 2.3? |
|
👍 Perfect pull request! By the way, you don't need to worry about the right target branch. We have a nice tool that we use to merge which is able to do the rebase when merging. |
|
@xabbuh perfect! thanks for the tip. |
|
👍 |
|
Thank you @richardpq. |
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #5989). Discussion ---------- Fix words according context | Q | A | ---------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | n/a Commits ------- 57425f1 Fix words according context
|
Thanks for this perfect pull request Richard. Your changes have been squashed before being merged. That's why your pull request is shown as closed instead of merged. |
|
@xabbuh I'm glad to help, but what you mean by "Your changes have been squashed before being merged", when should I expect to see these changes :D? |
|
@richardpq Squashed means that the two commits of your pull request have been merged to one. In fact I would have expected the changes to be already visible, but I do not know the exact time the documentation is built. @javiereguiluz Can you help us here? |
|
@xabbuh it should be visible by now because doc is generated daily very early in the morning (European Time). |
|
@xabbuh Thanks again for your explanation. @javiereguiluz I don't see changes yet, maybe because LATAM's cache or something like that, If I don't see by tomorrow, should I ping you? |
|
@richardpq I don't see the changes either. This is probably a bug. I'll take a look, but feel free to ping me. Thanks! |
|
It took some time, but the new doc is available on symfony.com. Thanks for your contribution and for your patience. |
|
Great! have nice weekend On Sat, Dec 12, 2015 at 5:44 AM, Javier Eguiluz [email protected]
Atte. |
