[Contributing][Code] do not distinguish regular classes and API classes #5735
Conversation
xabbuh
commented
Sep 28, 2015
xabbuh
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | kind of (symfony/symfony#15977, symfony/symfony#15979) |
| Applies to | all |
| Fixed tickets |
|
I would just add a small note saying that these BC rules don't apply on classes/methods tagged as |
|
@stof We already have this caution blocks (and a similar one for classes):
|
|
Then fine. |
|
👍 |
| | Add a default value to an argument | Yes | Yes | | ||
| +-----------------------------------------------+---------------+---------------+ | ||
| +-----------------------------------------------+-----------------------------+ | ||
| | Use Case | Backwards Compatibility | |
There was a problem hiding this comment.
We should rethink this table. In the past some columns were Yes and others No, so the table made sense. But now everything is Yes.
There was a problem hiding this comment.
I think a table structure is very nice here. It's clear and it's consistent with the other "promises tables" below.
|
Nice work Christian - thanks! |
… and API classes (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Contributing][Code] do not distinguish regular classes and API classes | Q | A | ------------- | --- | Doc fix? | no | New docs? | kind of (symfony/symfony#15977, symfony/symfony#15979) | Applies to | all | Fixed tickets | Commits ------- 9794d58 do not distinguish regular classes and API classes
| Reduce visibility No | ||
| Move to parent class Yes | ||
| Add argument without a default value No | ||
| Add argument with a default value No |
There was a problem hiding this comment.
This was a brave change. Now it's impossible to extend existing public code with new functionality. Was this intended?
There was a problem hiding this comment.
This was the only option we had as PHP will complain anyway (see https://3v4l.org/6T2DO).
