Document the support of Mintty for colors #5726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stof
commented
Sep 26, 2015
stof
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes symfony/symfony#15915 |
| Applies to | 2.8+ (or 2.3+ depending on where it gets merged) |
| Fixed tickets | n/a |
| On Windows, install the `ConEmu`_ or `ANSICON`_ free applications to see | ||
| colored test results. | ||
| On Windows, install the `ConEmu`_, `ANSICON`_ or `Mintty`_ free applications | ||
| to see colored test results. |
There was a problem hiding this comment.
hmm, this sentence is actually related to the PHPUnit color support. This means it depends on sebastianbergmann/environment#11 rather than on the Symfony PR (PHPUnit does not use the Console component)
|
👍 |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Sep 27, 2015
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #15915). Discussion ---------- Detect Mintty for color support on Windows | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | symfony/symfony-docs#5726 Mintty is now the default terminal in GitBash, and it supports ANSI colors without the need of ANSICON (it even supports 256 colors rather than the 16 colors supported by ANSICON). I submitted it to 2.8 as it can be considered as a new feature. But it should not be hard to merge it in other branches if we decide to consider it as a bugfix (it just needs to be split because VarDumper does not exist in 2.3) Commits ------- 12743d1 Detect Mintty for color support on Windows
|
The code has actually been merged in the 2.3 branch, so this now applies to 2.3+ |
stof
changed the title
|
@stof Should we wait here until sebastianbergmann/environment#11 gets merged or split this into two pull requests? |
|
Well, actually, you already get colors when running tests in Mintty now if you use the |
|
Thank you @stof. |
xabbuh
added a commit
that referenced
this pull request
Oct 3, 2015
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #5726). Discussion ---------- Document the support of Mintty for colors | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes symfony/symfony#15915 | Applies to | 2.8+ (or 2.3+ depending on where it gets merged) | Fixed tickets | n/a Commits ------- d8d4345 Document the support of Mintty for colors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.