Update cookbook entries with best practices #5674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JhonnyL
commented
Sep 4, 2015
JhonnyL
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets |
|
A big 👍 for this change! Thanks @JhonnyL for helping us getting rid of the old Acme bundle. |
|
👍 |
|
@JhonnyL Did you make some changes? Looks like some rebase went wrong. |
JhonnyL
force-pushed
the
update-cookbook-entries-with-best-practices
branch
from
b66a837
to
4e3ecb0
Compare
|
@xabbuh Sorry, should be fixed now |
|
Thank you @JhonnyL. |
xabbuh
added a commit
that referenced
this pull request
Sep 5, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Update cookbook entries with best practices | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Commits ------- 4e3ecb0 Update cookbook entries with best practices
| @@ -161,17 +161,17 @@ to and from the issue number and the ``Issue`` object:: | |||
| namespace AppBundle\Form\DataTransformer; | |||
|
|
|||
| use AppBundle\Entity\Issue; | |||
| use Doctrine\Common\Persistence\EntityManager; | |||
| use Doctrine\Common\Persistence\ObjectManager; | |||
There was a problem hiding this comment.
the changes in this document seems not to be related to this PR (but to #5666 instead, which I just merged).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.