Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a caution about logout when using http-basic authenticated firewall #5630

Merged
merged 1 commit into from
Feb 7, 2016

Conversation

rmed19
Copy link
Contributor

@rmed19 rmed19 commented Aug 17, 2015

Hi,
I found many developers on stackoverflow asking how to logout from http_basic auth in Symfony2.
So I added a caution about it.

Q A
Doc fix? no
New docs? yes
Applies to +2.3

@timglabisch
Copy link
Contributor

👍

@wouterj
Copy link
Member

wouterj commented Feb 6, 2016

Sorry for the big delay. I like this addition and think we should merge it: 👍 (btw, the lines have to be wrapped after the first word crossing the 72th column, however we can do it while merging).

@xabbuh xabbuh merged commit 3a0bd9d into symfony:2.3 Feb 7, 2016
xabbuh added a commit that referenced this pull request Feb 7, 2016
…cated firewall (rmed19)

This PR was merged into the 2.3 branch.

Discussion
----------

Add a caution about logout when using http-basic authenticated firewall

Hi,
I found many developers on stackoverflow asking how to logout from http_basic auth in Symfony2.
So I added a caution about it.

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | +2.3

Commits
-------

3a0bd9d Add a caution about logout when using http-basic authenticated firewall
xabbuh added a commit that referenced this pull request Feb 7, 2016
@xabbuh
Copy link
Member

xabbuh commented Feb 7, 2016

Thank you @rmed19. Your changes have been merged into the 2.3 branch from where they will be merged into all currently maintained branches. I also made some minor tweaks in 0ae9f60.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants