Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the installation chapter #5628

Merged
merged 1 commit into from
Aug 19, 2015
Merged

Updated the installation chapter #5628

merged 1 commit into from
Aug 19, 2015

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #5627

@javiereguiluz javiereguiluz mentioned this pull request Aug 17, 2015
Closed
wouterj
wouterj reviewed Aug 17, 2015
View reviewed changes
book/installation.rst
@@ -98,9 +98,6 @@ optional second argument of the ``new`` command:
$ symfony new my_project_name 2.3.26
$ symfony new my_project_name 2.6.5

# use the most recent LTS (Long Term Support) version
$ symfony new my_project_name lts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this not supported?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. In GitHub's split view it's easier to understand why I removed it (the explanation is duplicated!)

lts_repeated_explanation

@xabbuh
Copy link
Member

xabbuh commented Aug 17, 2015

👍

@wouterj
Copy link
Member

wouterj commented Aug 19, 2015

👍

@wouterj
Copy link
Member

wouterj commented Aug 19, 2015

Actually, the 2.3 did not have a new release since this change was merged. So things will be a bit weird for people reading the 2.3 docs. But well, who is reading the 2.3 installation docs now that the 2.7 LTS is already released?

@xabbuh
Copy link
Member

xabbuh commented Aug 19, 2015

Which feature do you mean?

@wouterj
Copy link
Member

wouterj commented Aug 19, 2015

@xabbuh the new SE homepage (and the existence of the / route rather than the /app/example route)

@javiereguiluz
Copy link
Member Author

A new 2.3 version will be released "soon" and most newcomers start with 2.7 anyway, so I guess we can safely merge it as it is now.

@xabbuh xabbuh merged commit 11fae59 into symfony:2.3 Aug 19, 2015
xabbuh added a commit that referenced this pull request Aug 19, 2015
@xabbuh
minor #5628 Updated the installation chapter (javiereguiluz)
f452b6e 
This PR was merged into the 2.3 branch.

Discussion
----------

Updated the installation chapter

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #5627

Commits
-------

11fae59 Updated the installation chapter
@xabbuh
Copy link
Member

xabbuh commented Aug 19, 2015

Yeah, I think that's not really an issue since - like you said - people probably don't start new projects with 2.3 anymore.

@javiereguiluz javiereguiluz mentioned this pull request Sep 11, 2015
Closed
@javiereguiluz javiereguiluz deleted the fix_5627 branch May 24, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @xabbuh @wouterj