2.3 #5569

ThomasLandauer · 2015-07-28T14:03:13Z

No description provided.

| Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [2.3] | Fixed tickets | []

| Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [yes] | Applies to | [2.3] | Fixed tickets | []

| Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [2.3] | Fixed tickets | [] I guess it's not necessary to do anything in __construct manually - the ArrayCollection is automatically initialized when you do php app/console doctrine:generate:entities AppBundle Please double-check!

| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets |

Removed unnecessary(?) YAML hint

Fixed typo

Note about nesting blocks and {% endblock NAME %}

Changed <meta http-equiv> to HTML5's <meta charset>

wouterj · 2015-07-28T14:13:41Z

book/doctrine.rst

@@ -951,8 +951,6 @@ To relate the ``Category`` and ``Product`` entities, start by creating a
                products:
                    targetEntity: Product
                    mappedBy: category
-            # don't forget to init the collection in the __construct() method


I think this comment is kind of usefull (and not everyone uses doctrine:generate:entities, even more it's better to never use this command).

OK, then please change it to:
The ArrayCollection $products is automatically initialized in the __construct() method, when you call doctrine:generate:entities

wouterj · 2015-07-28T14:14:13Z

I like the other changes! (btw, can you please remove your merge commits from the commit history?)

ThomasLandauer · 2015-07-28T14:39:42Z

Sorry, I'm new to GitHub and don't know where to delete what :-(
Took me a while to even figure out that I did not effectively create the Pull Request at the time I wrote the changes ;-)

stof · 2015-07-28T14:42:51Z

@wouterj you can squash the commits with the GH tool anyway, so this is not a hard requirement

wouterj · 2015-07-28T14:49:18Z

@ThomasLandauer no worries, I'll delete them when merging in that case.

ThomasLandauer · 2015-07-28T14:55:08Z

Thanks :-)

| Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [2.3] | Fixed tickets |[]

Typo: Removed comma

xabbuh · 2015-07-28T19:01:15Z

book/forms.rst

@@ -97,7 +97,7 @@ from inside a controller::
                ->getForm();

            return $this->render('default/new.html.twig', array(
-                'form' => $form->createView(),
+                'form' => $form->createView()


This should be reverted to comply with the Symfony CS.

| Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [2.3] | Fixed tickets | []

"app/Resources/views/Form/fields.html.twig" didn't work for me - see next code block: "form_theme form 'AppBundle:Form:fields.html.twig'" If this change is correct, I guess it needs to be corrected multiple times on this page.

Fixed file path

"the form" sounded like the HTML form. | Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [2.3] | Fixed tickets | []

stof · 2015-08-01T11:40:27Z

cookbook/form/form_customization.rst

@@ -282,7 +282,7 @@ can now re-use the form customization across many templates:

 .. code-block:: html+jinja

-    {# app/Resources/views/Form/fields.html.twig #}
+    {# src/AppBundle/Resources/views/Form/fields.html.twig #}


this looks wrong to me. Best practices are to put templates in app/Resources/views

Anyhow. My point is that the path used in the code exampled throughout this page is inconsistent! I don't know what the best practice is. If you don't want to change it here, then please change it in the next codeblock (and probably some others).

wouterj · 2015-12-19T15:29:54Z

Hi @ThomasLandauer!

I've taken your commits and added a new commit to revert some changes (but I kept most of them!) and fixed the template name inconsistency. I put these commits in a new PR: #6050

So I'm going to close this PR, but your contributions are not lost and you still get the credits.

Thanks for helping us improving the documentation, I'm amazed you discovered these errors and took time to fix them! 🎄

ThomasLandauer · 2015-12-20T10:59:09Z

Thanks :-)

…kbook doc (ThomasLandauer, WouterJ) This PR was merged into the 2.3 branch. Discussion ---------- Lots of minor fixes & applying best practices to form cookbook doc This finishes #5569 | Q | A | --- | --- | doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | - Commits ------- 99cdc00 Revert some changes and fix template names 2b00abe Minor clarification 3ce46f6 Fixed file path d227ffb Fixed typo 44d19de Added example for 'required' => false ebb1e74 Update templating.rst d806300 Typo: Removed comma 6e41f57 Another typo a4f0318 Fixed typo 275c079 Removed unnecessary(?) YAML hint 9cd391b Note about nesting blocks and {% endblock NAME %} 41f7e6f Changed <meta http-equiv> to HTML5's <meta charset>

ThomasLandauer added 9 commits June 28, 2015 16:54

Changed <meta http-equiv> to HTML5's <meta charset>

8700975

| Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [2.3] | Fixed tickets | []

Note about nesting blocks and {% endblock NAME %}

87e2c1e

| Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [yes] | Applies to | [2.3] | Fixed tickets | []

Fixed typo

cd009c7

| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets |

Another typo

526ead0

Merge pull request #3 from ThomasLandauer/ThomasLandauer-patch-3

0875f78

Removed unnecessary(?) YAML hint

Merge pull request #4 from ThomasLandauer/ThomasLandauer-patch-4

cbc3e26

Fixed typo

Merge pull request #2 from ThomasLandauer/ThomasLandauer-patch-2

8e5813c

Note about nesting blocks and {% endblock NAME %}

Merge pull request #1 from ThomasLandauer/ThomasLandauer-patch-1

826a463

Changed <meta http-equiv> to HTML5's <meta charset>

wouterj reviewed Jul 28, 2015
View reviewed changes

wouterj added the Status: Needs Work label Jul 28, 2015

wouterj added Status: Reviewed and removed Status: Needs Work labels Jul 28, 2015

ThomasLandauer added 2 commits July 28, 2015 19:07

Typo: Removed comma

eed20da

| Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [2.3] | Fixed tickets |[]

Merge pull request #5 from ThomasLandauer/ThomasLandauer-patch-1

d893965

Typo: Removed comma

xabbuh reviewed Jul 28, 2015
View reviewed changes

ThomasLandauer added 6 commits July 28, 2015 21:28

Update templating.rst

52dcecd

Added example for 'required' => false

8561baa

| Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [2.3] | Fixed tickets | []

Fixed typo

01ab074

| Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [2.3] | Fixed tickets | []

Fixed file path

f154514

"app/Resources/views/Form/fields.html.twig" didn't work for me - see next code block: "form_theme form 'AppBundle:Form:fields.html.twig'" If this change is correct, I guess it needs to be corrected multiple times on this page.

Merge pull request #6 from ThomasLandauer/ThomasLandauer-patch-5

f57c14c

Fixed file path

Minor clarification

e5fbbf7

"the form" sounded like the HTML form. | Q | A | ------------- | --- | Doc fix? | [yes] | New docs? | [no] | Applies to | [2.3] | Fixed tickets | []

stof reviewed Aug 1, 2015
View reviewed changes

xabbuh added the Status: Needs Work label Oct 9, 2015

xabbuh removed the Status: Reviewed label Oct 9, 2015

wouterj mentioned this pull request Dec 19, 2015

Lots of minor fixes & applying best practices to form cookbook doc #6050

Merged

wouterj closed this Dec 19, 2015

ThomasLandauer deleted the 2.3 branch August 17, 2018 09:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2.3 #5569

2.3 #5569

ThomasLandauer commented Jul 28, 2015

wouterj Jul 28, 2015

ThomasLandauer Jul 28, 2015

wouterj commented Jul 28, 2015

ThomasLandauer commented Jul 28, 2015

stof commented Jul 28, 2015

wouterj commented Jul 28, 2015

ThomasLandauer commented Jul 28, 2015

xabbuh Jul 28, 2015

stof Aug 1, 2015

ThomasLandauer Aug 1, 2015

wouterj commented Dec 19, 2015

ThomasLandauer commented Dec 20, 2015

2.3 #5569

2.3 #5569

Conversation

ThomasLandauer commented Jul 28, 2015

wouterj Jul 28, 2015

Choose a reason for hiding this comment

ThomasLandauer Jul 28, 2015

Choose a reason for hiding this comment

wouterj commented Jul 28, 2015

ThomasLandauer commented Jul 28, 2015

stof commented Jul 28, 2015

wouterj commented Jul 28, 2015

ThomasLandauer commented Jul 28, 2015

xabbuh Jul 28, 2015

Choose a reason for hiding this comment

stof Aug 1, 2015

Choose a reason for hiding this comment

ThomasLandauer Aug 1, 2015

Choose a reason for hiding this comment

wouterj commented Dec 19, 2015

ThomasLandauer commented Dec 20, 2015