Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Create Framework] Fix extract calls (replaces #5522) #5568

Merged
merged 1 commit into from
Jul 28, 2015
Merged

[Create Framework] Fix extract calls (replaces #5522) #5568

merged 1 commit into from
Jul 28, 2015

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jul 28, 2015

No description provided.

@wouterj wouterj mentioned this pull request Jul 28, 2015
Merged
@wouterj wouterj merged commit a9d75c6 into symfony:2.3 Jul 28, 2015
wouterj added a commit that referenced this pull request Jul 28, 2015
@wouterj
minor #5568 [Create Framework] Fix extract calls (replaces #5522) (ke…
29c80ce 
…njis)

This PR was merged into the 2.3 branch.

Discussion
----------

[Create Framework] Fix extract calls (replaces #5522)

Commits
-------

a9d75c6 Fix code
@wouterj wouterj deleted the kenjis-patch-2 branch July 28, 2015 13:27
@stof
Copy link
Member

stof commented Aug 1, 2015

This could still overwrite the $request variable, which would change what the template would receive

@xabbuh xabbuh mentioned this pull request Aug 4, 2015
Merged
@xabbuh
Copy link
Member

xabbuh commented Aug 4, 2015

see #5597

wouterj added a commit that referenced this pull request Aug 20, 2015
@wouterj
minor #5597 [CreateFramework] don't override existing variables (xabbuh)
c0676f3 
This PR was merged into the 2.3 branch.

Discussion
----------

[CreateFramework] don't override existing variables

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #5568

When extracting the request attributes, existing variables must not be
overridden so that the `$request` variable is passed to the template as
is.

Commits
-------

4b23fdc don't override existing variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wouterj @stof @xabbuh @kenjis