Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.3] [Contributing] Added note about empty returns #5557

Merged
merged 1 commit into from
Jul 25, 2015
Merged

[2.3] [Contributing] Added note about empty returns #5557

merged 1 commit into from
Jul 25, 2015

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Jul 23, 2015

Q A
Doc fix? no
New docs? no
Applies to
Fixed tickets

@wouterj
Copy link
Member

wouterj commented Jul 23, 2015

👍

xabbuh
xabbuh reviewed Jul 23, 2015
View reviewed changes
contributing/code/standards.rst
@@ -112,6 +112,9 @@ Structure
* Add a blank line before ``return`` statements, unless the return is alone
inside a statement-group (like an ``if`` statement);

* Use just ``return;`` instead ``return null;`` when a function must return void
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xabbuh.

@phansys
[2.3] [Contributing] Added note about empty returns
a6e9a10 
| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | no
| Applies to    |
| Fixed tickets |
@xabbuh
Copy link
Member

xabbuh commented Jul 25, 2015

Thank you Javier.

@xabbuh xabbuh merged commit a6e9a10 into symfony:2.3 Jul 25, 2015
xabbuh added a commit that referenced this pull request Jul 25, 2015
@xabbuh
minor #5557 [2.3] [Contributing] Added note about empty returns (phan…
81914ac 
…sys)

This PR was merged into the 2.3 branch.

Discussion
----------

[2.3] [Contributing] Added note about empty returns

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | no
| Applies to    |
| Fixed tickets |

Commits
-------

a6e9a10 [2.3] [Contributing] Added note about empty returns
@phansys
Copy link
Contributor Author

phansys commented Jul 25, 2015

Thank you too Christian.

@phansys phansys deleted the return_void branch July 25, 2015 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phansys @wouterj @xabbuh