Fix typo Esi in part create framework #5556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 you are right <?php
/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <[email protected]>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Symfony\Component\HttpKernel\HttpCache;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\HttpKernelInterface;
/**
* Esi implements the ESI capabilities to Request and Response instances.
*
* For more information, read the following W3C notes:
*
* * ESI Language Specification 1.0 (http://www.w3.org/TR/esi-lang)
*
* * Edge Architecture Specification (http://www.w3.org/TR/edge-arch)
*
* @author Fabien Potencier <[email protected]>
*/
class Esi implements SurrogateInterface
{
private $contentTypes;
... |
|
👍 |
| @@ -153,7 +153,7 @@ sub-requests to convert them to their proper content:: | |||
| $framework = new HttpKernel\HttpCache\HttpCache( | |||
| $framework, | |||
| new HttpKernel\HttpCache\Store(__DIR__.'/../cache'), | |||
| new HttpKernel\HttpCache\ESI() | |||
| new HttpKernel\HttpCache\Esi() | |||
There was a problem hiding this comment.
Shouldn't we also fix the namespace (the Symfony\Component part is missing and there is no use statement for it)?
|
Wow, this error isn't even discovered by PHP, but you found it and fixed it. Thanks! |
wouterj
added a commit
that referenced
this pull request
Jul 28, 2015
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5556). Discussion ---------- Fix typo Esi in part create framework | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Name for Esi class was wrong : ESI -> Esi Commits ------- 43e06c3 Fix typo Esi in part create framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name for Esi class was wrong : ESI -> Esi