Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the entity is updated. #5449

Closed
wants to merge 1 commit into from
Closed

Ensure that the entity is updated. #5449

wants to merge 1 commit into from

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Jun 26, 2015

Q A
Doc fix? yes
New docs? no
Applies to All
Fixed tickets #5448

@yceruto
Ensure that the entity is updated.
6202341 
| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | All
| Fixed tickets | symfony#5448
@wouterj
Copy link
Member

wouterj commented Jul 28, 2015

Thank you @yceruto! I've labelled it as finished, although I'm not sure if it's correct (I don't know much about the logic behind these file upload chapters). So I let other doc maintainers decide whether to merge it or not.

Please also note that this article is likely to be removed soon: #2346 (comment)

@xabbuh
Copy link
Member

xabbuh commented Jul 28, 2015

I remember that we recently had an issue/pull request were someone requested a similar change. Unfortunately, I cannot find it anymore.

@yceruto
Copy link
Member Author

yceruto commented Aug 5, 2015

the problem lies in this commit 15ccf24

yceruto referenced this pull request Aug 5, 2015
@mahmouds
fix a case when you set only the file field for the first time
15ccf24
@xabbuh
Copy link
Member

xabbuh commented Aug 5, 2015

👍 We really need to facelift the article, but this change should at least fix the issue described in #5448.

@weaverryan
Copy link
Member

Thanks @yceruto for the fix!

@weaverryan weaverryan closed this in b892f48 Aug 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yceruto @wouterj @xabbuh @weaverryan