Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users of older PHP versions Crawler might not decode HTML entities properly #5433

Merged
merged 2 commits into from
Jun 28, 2015

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? yes
New docs? no
Applies to 2.3,<2.7
Fixed tickets -

@xabbuh
Copy link
Member

xabbuh commented Jun 24, 2015

👍

1 similar comment
@wouterj
Copy link
Member

wouterj commented Jun 27, 2015

👍

@xabbuh xabbuh merged commit 699e637 into symfony:2.3 Jun 28, 2015
xabbuh added a commit that referenced this pull request Jun 28, 2015
… HTML entities properly (jakzal, javiereguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Warn users of older PHP versions Crawler might not decode HTML entities properly

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3,<2.7
| Fixed tickets | -

Commits
-------

699e637 Reworded the notice as a caution
c47ec88 [DomCrawler] Warn users of older PHP versions Crawler might not decode html entities properly.
@xabbuh
Copy link
Member

xabbuh commented Jun 28, 2015

Thanks @jakzal for the initial commit and thanks to @javiereguiluz for finishing it.

@javiereguiluz javiereguiluz deleted the pr/5248 branch May 24, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants