Update http_fundamentals.rst #5352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should probably explain that all modern browsers support these methods in XHR, but that HTML forms still can only use GET and POST. |
|
You're right. I'll get on to it :) |
|
Oh, and we also have a part talking about this at http://symfony.com/doc/current/cookbook/routing/method_parameters.html#faking-the-method-with-method. Could you please address that section too? |
|
👍 @wouthoekstra for taking care of this :) |
Added some nuance to note about PUT and DELETE in modern browsers.
|
This looks good! 👍 |
|
@wouthoekstra By the way, we don't receive notifications when new commits are pushed to a pull request (I just discovered your update "accidentally"). So next time it's better to leave a comment after you did some changes. :) |
|
Ah thx for the tip xabbuh, didn't know that! Glad the alterations are okay :) |
weaverryan
added a commit
that referenced
this pull request
Jul 12, 2015
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #5352). Discussion ---------- Update http_fundamentals.rst Modern browsers do support PUT and DELETE, see for example http://stackoverflow.com/questions/165779/are-the-put-delete-head-etc-methods-available-in-most-web-browsers. Commits ------- 1bc5228 Updated text about HTTP methods 46f3665 Update http_fundamentals.rst
weaverryan
added a commit
that referenced
this pull request
Jul 12, 2015
|
I like it very much - nice work @wouthoekstra! I've merged this into the 2.3 branch (and we'll merge to other branches from there) and added a minor tweak at sha: f9ef3ee Cheers! |
|
Sounds good! Sorry, I understood only after my pull request that I should have made the request on the 2.3 branch, not on the latest one. |
weaverryan
added a commit
that referenced
this pull request
Jul 12, 2015
* 2.3: [#5352] minor language tweak Updated text about HTTP methods Update http_fundamentals.rst [HttpKernel] Fix use statement Fixes small typo in data transformers cookbook some tweaks to the data transformers chapter Updated the Symfony Versions Roadmap image Fixed a minor typo Fixed minor issues Removed some information wrongly rebased Style / grammar fixes for the deployment chapter Style / grammar fixes for the controller chapter Style / grammar fixes for the console chapter Removes wrong comma Rewritten 'whether' & removed serial comma Style / grammar fixes for the configuration chapter Style / grammar fixes for the cache chapter Style / grammar fixes for the bundles chapter Style / grammar fixes for the assetic chapter
weaverryan
added a commit
that referenced
this pull request
Jul 12, 2015
* 2.6: [#5352] minor language tweak Updated text about HTTP methods Update http_fundamentals.rst [HttpKernel] Fix use statement Fixes small typo in data transformers cookbook some tweaks to the data transformers chapter Updated the Symfony Versions Roadmap image Fixed a minor typo Fixed minor issues Removed some information wrongly rebased Style / grammar fixes for the deployment chapter Style / grammar fixes for the controller chapter Style / grammar fixes for the console chapter Removes wrong comma Rewritten 'whether' & removed serial comma Style / grammar fixes for the configuration chapter Style / grammar fixes for the cache chapter Style / grammar fixes for the bundles chapter Style / grammar fixes for the assetic chapter
weaverryan
added a commit
that referenced
this pull request
Jul 12, 2015
* 2.7: (21 commits) [#5352] minor language tweak Updated text about HTTP methods Update http_fundamentals.rst [HttpKernel] Fix use statement [PSR-7] Fix Diactoros link Fixes small typo in data transformers cookbook some tweaks to the data transformers chapter Updated the Symfony Versions Roadmap image Fixed a minor typo Fixed minor issues Use the built-in serializer instead of promoting JMS Removed some information wrongly rebased Style / grammar fixes for the deployment chapter Style / grammar fixes for the controller chapter Style / grammar fixes for the console chapter Removes wrong comma Rewritten 'whether' & removed serial comma Style / grammar fixes for the configuration chapter Style / grammar fixes for the cache chapter Style / grammar fixes for the bundles chapter ...
weaverryan
added a commit
that referenced
this pull request
Jul 12, 2015
* 2.8: (21 commits) [#5352] minor language tweak Updated text about HTTP methods Update http_fundamentals.rst [HttpKernel] Fix use statement [PSR-7] Fix Diactoros link Fixes small typo in data transformers cookbook some tweaks to the data transformers chapter Updated the Symfony Versions Roadmap image Fixed a minor typo Fixed minor issues Use the built-in serializer instead of promoting JMS Removed some information wrongly rebased Style / grammar fixes for the deployment chapter Style / grammar fixes for the controller chapter Style / grammar fixes for the console chapter Removes wrong comma Rewritten 'whether' & removed serial comma Style / grammar fixes for the configuration chapter Style / grammar fixes for the cache chapter Style / grammar fixes for the bundles chapter ...
|
Nice! @weaverryan you've just merged @wouthoekstra's first Pull! 👍 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern browsers do support PUT and DELETE, see for example http://stackoverflow.com/questions/165779/are-the-put-delete-head-etc-methods-available-in-most-web-browsers.