[Console] Command Lifecycle explications

[94noni]

Q	A
Doc fix?	yes
New docs?	no
Applies to	2.3+
Fixed tickets	#4996, #4366

Hi

I took the doc form https://github.com/symfony/symfony-demo/blob/master/src/AppBundle/Command/AddUserCommand.php by @javiereguiluz as a minimal explanations for this, which IMO could be beneficial for devs

[xabbuh]

Thank you for starting this @94noni. However, I think we should use a definition list for this:

Commands have three lifecycle methods:

:method:`Symfony\\Component\\Console\\Command\\Command::initialize`

    This method is executed before the ``interact()`` and the ``execute()``
    methods. It's main purpose is to initialize the variables used in the
    rest of the command methods.

:method:`Symfony\\Component\\Console\\Command\\Command::interact`

    This method is executed after ``initialize()`` and before ``execute()``.
    Its purpose is to check if some of the options/arguments are missing
    and interactively ask the user for those values.

:method:`Symfony\\Component\\Console\\Command\\Command::execute`

    This method is executed after ``interact()`` and ``initialize()``. It
    usually contains the logic to execute to complete this command task.

    Note that ``execute()`` is the only required method of the three. The
    ``initialize()`` and ``interact()`` methods are completely optional.

What do you think?

[94noni]

As you wish for formating
I can replace my pr by your code if its ok
Or close this and you open a new one

[wouterj]

@94noni you can edit your branch in your fork to automatically update this PR. As you were the one starting this - and we are just maintainers - we would very much like it to have your name attached to these changes, so if you can update, please do so :)

[94noni]

Changes are done, ping @wouterj :)

[xabbuh]

We need to remove "to complete" to make this readable I guess.

[94noni]

Ok of course,
but It usually contains the logic to execute this command task. seems not good
What about It contains the logic you want the command executes ?

[javiereguiluz]

I think we need a separation here:

[...] options/arguments otherwise [...]

[...] options/arguments. Otherwise [...]

[javiereguiluz]

@94noni 👍 thanks for this addition! I've left some minor comments. They can probably be addressed by the documentation merger, so there is no need for you to update this PR. Thanks!

[OskarStark]

@javiereguiluz so we can add the Finished-Label here?

[javiereguiluz]

@OskarStark I don't know. Labeling issues is done only by our doc managers (@wouterj and @xabbuh).

[wouterj]

Thank you Antoine for adding this nice bit of missing docs! I've merged it into the docs and applied the comments by Javier and did some other minor tweaks in 01965cc

Also thanks to @OskarStark for the ping :)

[noniagriconomie]

Fine ty :)
edit : Oups other account lol