[Cookbook] [Deployment] Added note about Nginx #5216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phansys
commented
Apr 28, 2015
phansys
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3+ |
| Fixed tickets |
| @@ -106,6 +106,15 @@ directory of the application and add just the following content: | |||
|
|
|||
| web: bin/heroku-php-apache2 web/ | |||
|
|
|||
| .. note:: | |||
|
|
|||
| Nginx is also available in Heroku. If you prefer to use it, you can create a | |||
There was a problem hiding this comment.
Thank you @xabbuh, fixed.
| .. note:: | ||
|
|
||
| Nginx is also available on Heroku. If you prefer to use it, you can create a | ||
| Nginx config file (``nginx_app.conf`` for instance) to point from Procfile as described in `Heroku docs`_: |
There was a problem hiding this comment.
I think we should reword the paragraph a bit like this:
If you prefer to use Nginx, which is also available on Heroku, you can create a configuration file for it and point to it from your Procfile as described in the Heroku documentation.
What do you think about this @phansys?
There was a problem hiding this comment.
This sounds better. Updated.
|
👍 nice work @phansys |
|
Should I rebase the PR and resolve the conflicts? |
phansys
force-pushed
the
deploy_heroku
branch
3 times, most recently
from
8ebb689 to
c39f20e
Compare
|
@phansys That would be nice. |
| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets |
|
@xabbuh, done. Thanks. |
|
I love it! Thanks Javier! |
weaverryan
added a commit
that referenced
this pull request
May 23, 2015
This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook] [Deployment] Added note about Nginx | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | Commits ------- 751d0df [Cookbook] [Deployment] Added note about Nginx setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.