Reviewed the Bundles cookbook articles #5095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javiereguiluz
commented
Mar 19, 2015
javiereguiluz
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | - |
| @@ -68,22 +71,46 @@ The only thing you need to do now is register the bundle in ``AppKernel``:: | |||
| } | |||
| } | |||
|
|
|||
| By default, Symfony bundles are registered in all the application | |||
| :doc:`execution environments <cookbook/configuration/environments>`. If the bundle | |||
| A test suite must not contain ``AllTests.php`` scripts, but must rely on the | ||
| existence of a ``phpunit.xml.dist`` file. | ||
|
|
||
| Documentation | ||
| ------------- | ||
|
|
||
| All classes and functions must come with full PHPDoc. | ||
| All classes and functions must be fully documented using `phpDocumentor`_ tags. |
There was a problem hiding this comment.
why phpDocumentor if Symfony relies on Sami and other PHPdoc generators are popular too?
javiereguiluz
force-pushed
the
update_bundles_cookbook
branch
from
b2cb6f1 to
82b6921
Compare
|
I've just fixed the conflicts of this PR. I think it's ready to be merged, because Wouter's concerns are taken into account (the first example removes the version number because of how we explain things and there is a note explaining that ... the second example shows a |
javiereguiluz
force-pushed
the
update_bundles_cookbook
branch
from
588bac0 to
8008ac6
Compare
|
I've made all the proposed changes and I've fixed all the conflicts. Please, review it for the last time, label it as |
|
👍 |
weaverryan
added a commit
that referenced
this pull request
Jun 9, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Reviewed the Bundles cookbook articles | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Commits ------- 8008ac6 Implemented the suggestions made by Christian and Wouter 8861215 Replace phpDocumentor by the standard PHPDoc c0637b6 Implemented the changes suggested by reviewers 3dd40b2 Fixed an internal link reference 8254761 Reviewed the Bundles cookbook articles
weaverryan
added a commit
that referenced
this pull request
Jun 9, 2015
|
Thanks Javier! Minor tweaks at sha: ae35338 |
weaverryan
added a commit
that referenced
this pull request
Jun 19, 2015
* 2.3: [#5373] Small tweak per Stof's comment Fixed a minor grammar issue Fixed typos Link to the official repository of the bundle. Added mentions to some popular (and useful) Symfony bundles [#5095] Fixing a typo and updating to a more realistic example [#4228] Move synthetic services to its own recipe clarify bundle installation instructions Implemented the suggestions made by Christian and Wouter Replace phpDocumentor by the standard PHPDoc Implemented the changes suggested by reviewers Fixed an internal link reference Reviewed the Bundles cookbook articles Constraints - empty strings and null values Add a caution to the getUploadRootDir - correction Adding a caution to the getUploadRootDir() method [#4228] Moved requiring files to definitions
weaverryan
added a commit
that referenced
this pull request
Jun 19, 2015
* 2.6: [#5373] Small tweak per Stof's comment Fixed a minor grammar issue Fixed typos Link to the official repository of the bundle. Added mentions to some popular (and useful) Symfony bundles [#5095] Fixing a typo and updating to a more realistic example [Components][ClassLoader] remove DebugClassLoader [#4228] Move synthetic services to its own recipe clarify bundle installation instructions Implemented the suggestions made by Christian and Wouter Replace phpDocumentor by the standard PHPDoc Implemented the changes suggested by reviewers Fixed an internal link reference Reviewed the Bundles cookbook articles Constraints - empty strings and null values Add a caution to the getUploadRootDir - correction Adding a caution to the getUploadRootDir() method [#4228] Moved requiring files to definitions
weaverryan
added a commit
that referenced
this pull request
Jun 19, 2015
* 2.7: (23 commits) [#5331] Tiny typo [#5373] Small tweak per Stof's comment [PSR-7] Bridge documentation Fix after install URL and new photo since AcmeDemoBundle is not part of 2.7 Fixed a minor grammar issue Fixed typos Link to the official repository of the bundle. Added mentions to some popular (and useful) Symfony bundles [#5095] Fixing a typo and updating to a more realistic example [Components][ClassLoader] remove DebugClassLoader [#4228] Move synthetic services to its own recipe clarify bundle installation instructions Implemented the suggestions made by Christian and Wouter Replace phpDocumentor by the standard PHPDoc Implemented the changes suggested by reviewers Fixed an internal link reference Reviewed the Bundles cookbook articles Updated the list of reserved domains and the URL reference Use the reserved domains example.com and example.org Constraints - empty strings and null values ...
weaverryan
added a commit
that referenced
this pull request
Jun 19, 2015
* 2.8: (24 commits) [#5331] Tiny typo [#5373] Small tweak per Stof's comment Added depreciation note for the cascade_validation constraint and updated position of depreciation notes [PSR-7] Bridge documentation Fix after install URL and new photo since AcmeDemoBundle is not part of 2.7 Fixed a minor grammar issue Fixed typos Link to the official repository of the bundle. Added mentions to some popular (and useful) Symfony bundles [#5095] Fixing a typo and updating to a more realistic example [Components][ClassLoader] remove DebugClassLoader [#4228] Move synthetic services to its own recipe clarify bundle installation instructions Implemented the suggestions made by Christian and Wouter Replace phpDocumentor by the standard PHPDoc Implemented the changes suggested by reviewers Fixed an internal link reference Reviewed the Bundles cookbook articles Updated the list of reserved domains and the URL reference Use the reserved domains example.com and example.org ...
javiereguiluz
pushed a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Sep 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.