A very quick reread of the Form Login article #5036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wouterj
commented
Feb 21, 2015
wouterj
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | - |
| public function loginAction(Request $request) | ||
| { | ||
| // todo... | ||
| } | ||
| } | ||
|
|
||
| Next, create two routes: one for each of the paths your configured earlier |
There was a problem hiding this comment.
nice catch - got it at sha: e245303
weaverryan
added a commit
that referenced
this pull request
Mar 14, 2015
This PR was merged into the 2.3 branch. Discussion ---------- A very quick reread of the Form Login article | Q | A | --- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Commits ------- f804af9 Reread Form Login article
weaverryan
added a commit
that referenced
this pull request
Mar 14, 2015
|
This kind if stuff is SUCH a big win. Docs "degrade" in their consistency over time. Thanks a lot of this :). |
weaverryan
added a commit
that referenced
this pull request
Mar 14, 2015
* 2.3: (30 commits) [#5064] Minor language tweaks Switched the first example to a static constructor method added some more components for Tobion as a merger Fixed variable name in : Reference -> validation constraints -> count -> basic usage -> PHP [#5036] Typo fix (probably mine originally) caught by xabbuh reword to serves Adding a link to define "lts" Better wording Minor improvement for symfony-installer with LTS link to deciders' GitHub profiles Add missing use statement in Building Login Form doc Also removed use statement for Route as it is only needed when using annotations for routing Fixed incorrect plural form Improved the URL of the English reference dictionary Reworded the paragraph about enforcing an English reference enclose data type with double backticks Rewords, tweaks and fixes Updated documentation standards (code examples and English use) Added double backticks. And also a full stop. added link target/label in the cookbook Changed link into ref ... Conflicts: components/config/definition.rst contributing/code/core_team.rst cookbook/security/form_login_setup.rst
weaverryan
added a commit
that referenced
this pull request
Mar 14, 2015
* 2.6: (91 commits) [#5064] Minor language tweaks Fixing bad merge conflict (forgot to save!) Remove unnecessary component reference Correct RegisterListenersPass namespace Fix service id Switched the first example to a static constructor method added some more components for Tobion as a merger Fixed variable name in : Reference -> validation constraints -> count -> basic usage -> PHP [#5036] Typo fix (probably mine originally) caught by xabbuh reword to serves Adding a link to define "lts" Better wording Minor improvement for symfony-installer with LTS Updating for new security service names in 2.6 [#5033] Tweaking variable name to "match" the service id [#5017] Minor language tweaks [#5015] Updating the security service name for 2.6 - thanks to Cordoval [#5015] Very small tweak [#5011] Adding one more fix I missed [#5011] Fixing minor build issue ... Conflicts: book/security.rst
weaverryan
added a commit
that referenced
this pull request
Mar 14, 2015
* 2.7: (103 commits) Backporting some stuff from 2.7, that I think must have gotten merged only there by accident [#5064] Minor language tweaks Fixing bad merge conflict (forgot to save!) Remove unnecessary component reference Correct RegisterListenersPass namespace Fix service id Switched the first example to a static constructor method added some more components for Tobion as a merger Fixed variable name in : Reference -> validation constraints -> count -> basic usage -> PHP [#5036] Typo fix (probably mine originally) caught by xabbuh reword to serves Adding a link to define "lts" Better wording Minor improvement for symfony-installer with LTS Updating for new security service names in 2.6 [#5033] Tweaking variable name to "match" the service id [#5017] Minor language tweaks [#5015] Updating the security service name for 2.6 - thanks to Cordoval [#5015] Very small tweak [#5011] Adding one more fix I missed ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.