Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the_big_picture.rst #5034

Closed
wants to merge 1 commit into from
Closed

Update the_big_picture.rst #5034

wants to merge 1 commit into from

Conversation

oldskool
Copy link
Contributor

When following the steps in this documentation, I ended up with this: http://i.imgur.com/nK3XM2B.png
Got the suggestion to install the assets on the IRC channel and it did the trick for me. This addition to the docs might help others facing the same problem to make their app look as expected.

@xabbuh
Copy link
Member

xabbuh commented Feb 20, 2015

@oldskool Actually I think we should better change the URL to be http://localhost:8000/app_dev.php/ instead. Otherwise, you won't see the same as what is shown in the screenshot (for example, the web debug toolbar is not present in the prod environment).

@wouterj
Copy link
Member

wouterj commented Feb 20, 2015

@xabbuh the built-in server is used, which will always be in dev env unless you use --env=prod

@xabbuh
Copy link
Member

xabbuh commented Feb 20, 2015

@wouterj Hm, yes you're right. But why should it be needed at all then to manually install assets?

@wouterj
Copy link
Member

wouterj commented Feb 20, 2015

@xabbuh I need to do it quite often too. Most of the time, because the composer scripts fail at clearing the cache on installation, the script that installs the assets is then no longer executed.

@oldskool
Copy link
Contributor Author

@xabbuh I tried that as well, but that didn't render the assets either. In this part of the docs, the PHP built-in webserver is still used, so it seems that @wouterj is right about the dev environment already being used.

@xabbuh
Copy link
Member

xabbuh commented Feb 20, 2015

Any idea why this is failing on some systems?

@oldskool
Copy link
Contributor Author

No clue, running this PHP version on Windows 7 if it's of any help:

$ php -v
PHP 5.5.11 (cli) (built: Apr 8 2014 15:07:14)
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.5.0, Copyright (c) 1998-2014 Zend Technologies
with Xdebug v2.2.3, Copyright (c) 2002-2013, by Derick Rethans

@xabbuh
Copy link
Member

xabbuh commented May 23, 2015

Then let's merge this imo. It does not hurt and it may help people.

@oldskool Can you please rebase your PR?

@oldskool
Copy link
Contributor Author

@xabbuh Done.

@xabbuh
Copy link
Member

xabbuh commented May 25, 2015

👍


.. code-block:: bash

$ php app/console assets:install web
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we remove the "web" parameter?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think we should. @oldskool can you please add this change? I promise that we'll merge it after you've done that :)

When following the steps in this documentation, I ended up with this: http://i.imgur.com/nK3XM2B.png
Got the suggestion to install the assets on the IRC channel and it did the trick for me. This addition to the docs might help others facing the same problem to make their app look as expected.
@oldskool
Copy link
Contributor Author

oldskool commented Jun 1, 2015

@wouterj Done.

@wouterj
Copy link
Member

wouterj commented Jun 7, 2015

Thanks for the addition and your patience, Jan! It's merged into the 2.3 docs now.

wouterj added a commit that referenced this pull request Jun 7, 2015
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #5034).

Discussion
----------

Update the_big_picture.rst

When following the steps in this documentation, I ended up with this: http://i.imgur.com/nK3XM2B.png
Got the suggestion to install the assets on the IRC channel and it did the trick for me. This addition to the docs might help others facing the same problem to make their app look as expected.

Commits
-------

0676444 Update the_big_picture.rst
@wouterj wouterj closed this Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants