-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update forms.rst #4782
Update forms.rst #4782
Conversation
ifdattic
commented
Jan 6, 2015
Q | A |
---|---|
Doc fix? | yes |
New docs? | no |
Applies to | 2.3 |
Fixed tickets |
| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets |
use AppBundle\Entity\Task; | ||
use Symfony\Bundle\FrameworkBundle\Controller\Controller; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what is the convention, but I personally try to sort alphabetically (groups included if needed) when possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a convention I think (the code doesn't have one either, does it? /cc @stof )
I always sort on length of the seperate namespace items, but I don't care much :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC PHP-CS-Fixer sorts them alphabetically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From that I saw in others code I think most/all the time it's sorted alphabetically, just sometimes they are grouped adding the empty line between namespaces, but the groups are still sorted.
And when I use sublime editor it's not a lot of problems to do that, just add use statement anywhere, select a block and press F5, no need to process anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't separate use statements in several blocks in the code.
And we usually keep them sorted in new code, but we don't sort them in existing code when refactoring if there are not sorted properly to avoid useless conflicts when merging branches
ping @ifdattic :) |
@xabbuh Yes, how can I help? |
Can you rebase here? |
Maybe someone else could rebase? |
Glad to help! |