[Reference] Add default_locale config description #4711
Conversation
xelaris
commented
Dec 30, 2014
xelaris
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | all |
| Fixed tickets |
|
|
||
| This locale is used, if no ``_locale`` routing parameter has been set. It becomes | ||
| the service container parameter named ``kernel.default_locale``. It is also available | ||
| with the :method:`Request::getDefaultLocale <Symfony\\Component\\HttpFoundation\\Request::getDefaultLocale>` |
There was a problem hiding this comment.
Do we really need a custom label for the method role here?
|
Thanks @xabbuh I have updated the commit. I have just copied the method reference from https://github.com/symfony/symfony-docs/blame/2.3/reference/configuration/framework.rst#L78 Should I change it too? I also think the sentence is missing the word |
|
|
||
| **type**: ``string`` **default**: ``en`` | ||
|
|
||
| This locale is used if no ``_locale`` routing parameter has been set. It becomes |
There was a problem hiding this comment.
would prefer "The default locale is used ..." but i am also fine with merging this.
|
👍 |
Now that I think of this again, the way it is seems to be better given that you can see instantly to which class the method belongs.
I think the same. Can you add it in both sentences? |
|
Updated both sentences |
|
Thank you @xelaris |
|
This is really nice - great work everyone! |
…ris) This PR was merged into the 2.3 branch. Discussion ---------- [Reference] Add default_locale config description | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | all | Fixed tickets | Commits ------- 7ae3489 [Reference] Add default_locale config description
