Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OptionsResolver] Fix links to api methods #4621

Closed
wants to merge 1 commit into from

Conversation

xavren
Copy link
Contributor

@xavren xavren commented Dec 10, 2014

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #4620

@xabbuh
Copy link
Member

xabbuh commented Dec 10, 2014

Thank you for noticing this and providing a patch @xavren! 👍

However, before Symfony 2.6, you would have used the setNormalizers() method instead of the setNormalizer() method.The namespace for that method was wrong in older branches too. Do you like to create an additional pull request and fix it on the 2.3 branch too?

@weaverryan @wouterj This should be merged into the 2.6 branch.

@weaverryan
Copy link
Member

Hey @xavren!

Nice find and thanks for the PR! Would it be possible for you to rebase this against the latest symfony/master? I'm getting some really strange results trying to merge - it looks as if your master branch is many commits ahead of mine, which is causing a commits to try to re-play when I patch. I've never seen this before, and GitHub doesn't show it, so I'm not sure what happened :).

Thanks!

@xabbuh
Copy link
Member

xabbuh commented Dec 11, 2014

@weaverryan Can't you apply it cleanly on 2.6 instead of master?

@xavren
Copy link
Contributor Author

xavren commented Dec 11, 2014

@xabbuh @weaverryan Just did a new PR for 2.6 #4630

@xabbuh
Copy link
Member

xabbuh commented Dec 11, 2014

@xavren Thank you. Closing here then.

@xabbuh xabbuh closed this Dec 11, 2014
@weaverryan
Copy link
Member

@xabbuh yea, strangely I could not apply it cleanly - and the conflicts made no sense - that's never happened before :). Anyways - thanks again @xavren!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants