Replace form_enctype(form) with form_start(form). #4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since form_enctype(form) is deprecated since 2.3 form_start(form) should be used.
|
Thanks for the PR, @xelaris! It looks like a complete valid change (after the best practices were created, the authors of it wanted to undeprecate form_enctype, but after a discussion they decided to promote I wonder why Ryan didn't update this one in #4465 , maybe he overlooked this example? @weaverryan can you please merge this PR if you think this change is correct? |
|
Thanks Alexander! Yea, good thinking about checking Wouter - but I this was on accident - don't know how I missed it :). |
weaverryan
added a commit
that referenced
this pull request
Dec 7, 2014
This PR was merged into the 2.3 branch. Discussion ---------- Replace form_enctype(form) with form_start(form). | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | >=2.3 | Fixed tickets | Since form_enctype(form) is deprecated since 2.3 form_start(form) should be used. Commits ------- 21d69eb Replace form_enctype(form) with form_start(form).
wouterj
added a commit
that referenced
this pull request
Jun 6, 2015
…amodiere) This PR was merged into the 2.3 branch. Discussion ---------- [Form] Replace deprecated form_enctype by form_start Deprecated since 2.3. See [form chapter](http://symfony.com/doc/2.3/book/forms.html#rendering-the-form) | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | #4603 Commits ------- f771d15 Replace deprecated form_enctype by form_start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since form_enctype(form) is deprecated since 2.3 form_start(form) should be used.