remove service class parameters #4519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Nov 24, 2014
xabbuh
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | no |
| Applies to | all |
| Fixed tickets |
|
👍 |
|
This requires fixing conflicts though |
xabbuh
force-pushed
the
remove-class-parameters
branch
from
be9065f to
1fb20e5
Compare
|
Thanks, I rebased the changes. |
|
Awesome job again @xabbuh! This is exactly the old ugly stuff that I'm so happy to get out of the docs (since we're learned a bit!). Thanks! |
weaverryan
added a commit
that referenced
this pull request
Dec 7, 2014
This PR was merged into the 2.3 branch. Discussion ---------- remove service class parameters | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | all | Fixed tickets | Commits ------- 1fb20e5 remove service class parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.