change misleading language identifier #4284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kristofvc
commented
Oct 2, 2014
kristofvc
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3 |
| Fixed tickets | #4251 |
| @@ -8,8 +8,8 @@ The ``language`` type is a subset of the ``ChoiceType`` that allows the user | |||
| to select from a large list of languages. As an added bonus, the language names | |||
| are displayed in the language of the user. | |||
|
|
|||
| The "value" for each language is the *Unicode language identifier* | |||
| (e.g. ``fr`` or ``zh-Hant``). | |||
| The "value" for each language is the *Unicode language identifier* used in the `International Components for Unicode`_ | |||
There was a problem hiding this comment.
the ``International Components for Unicode_ should be put on the next line (in order to not exceed our 72th characters line rule)
|
I put the second part of the sentence on a new line if that's ok |
|
Looks good |
|
👍 I like it. |
|
Great work Kristof - thanks for fixing this! |
weaverryan
added a commit
that referenced
this pull request
Oct 3, 2014
…rgh, kristofvc) This PR was merged into the 2.3 branch. Discussion ---------- change misleading language identifier | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | #4251 Commits ------- db85c67 formatting to follow 72 characters line limit 12cccc8 changed dash to underscore d68cd09 change misleading language identifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.