[Reference] link translation DIC tags to components section #4247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `translation.loader` and `translation.dumper` DIC tags link to the respective sections in the Translation component documentation.
| .. seealso:: | ||
|
|
||
| Learn how to :ref:`dump to custom formats <components-translation-custom-dumper>` | ||
| in the components section. |
There was a problem hiding this comment.
this is too generic? or you really mean component singular
There was a problem hiding this comment.
Hm, don't you think it's clear enough with link directly pointing to the relevant part? Do you think that "[...] in the component's documentation" is better?
wouterj
added
actionable
|
Looks good to me - just a little less duplication :). Thanks! |
weaverryan
added a commit
that referenced
this pull request
Sep 22, 2014
…on (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Reference] link translation DIC tags to components section | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | The `translation.loader` and `translation.dumper` DIC tags link to the respective sections in the Translation component documentation (in addition to the changes done in #4166). Commits ------- 9790975 link translation DIC tags to components section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
translation.loaderandtranslation.dumperDIC tags link to the respective sections in the Translation component documentation (in addition to the changes done in #4166).