Added a note about the automatic handling of the memory spool in the CLI #4117
Conversation
|
Fixes #4111 |
|
Thanks Stof!�� |
…pool in the CLI (stof) This PR was merged into the 2.3 branch. Discussion ---------- Added a note about the automatic handling of the memory spool in the CLI | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | n/a since symfony/swiftmailer-bundle#64 flushing the memory spool manually is not necessary anymore when using Symfony 2.3+. I added a versionadded note here, but we might decide to remove the obsolete paragraph instead, making the cookbook only about generating urls (which would require renaming the page then) Commits ------- c99c70d Added a note about the automatic handling of the memory spool in the CLI
|
I went to http://symfony.com/doc/current/cookbook/console/sending_emails.html but I could not see the sentence "When using Symfony 2.3+ and SwiftmailerBundle 2.3.5+, the memory spool is now handled automatically in the CLI and the code below is not necessary anymore." anywhere on the page. Am I missing something? |
|
@TerjeBr currently, this is fixed in the 2.3 version of the doc. It is not yet merged into newer versions (the doc maintainers are merging each branch in the newer one on a regular basis so that we don't need to do each commit 4 times to reach all versions). |
|
f40bb24 But if the online docs are rebuild only every night, and it is not instant, that explains it. |
|
hmm, indeed, I missed the merge of branches together. So only the second part of my previous comment is relevant |
|
Normally, text changes are rebuild 30 min after the PR is merged, but maybe that's changed. |
|
Is there any reason at all to keep the obsolete paragraph about "Using Memory Spooling"? |
|
Curiously, I still don't see this rendered on the page :/. @javiereguiluz are we still right to assume that things are rebuilt every 30 minutes or so (with full rebuilds for things like totally new entries each night)? @TerjeBr I think the paragraph is still relevant, because some people may just not be using the new Swiftmailer version yet. |
|
It seems like that when you put this line in front And then indent it, that paragraph will not show up at all on the page. @weaverryan The functionality does not depend on the Swiftmailer version, but only on the Symfony version used. |
|
(the text didn't appear on the site, because it was now seen as a comment, since versionadded directives don't allow that empty line) |
|
Glad I could be to some help :) |
…ng on CLI (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook][Console] remove note about memory spool handling on CLI We added this note a long time ago in #4117, but I think we can now safely remove this part. Commits ------- 5eff7fd remove note about memory spool handling on CLI
since symfony/swiftmailer-bundle#64 flushing the memory spool manually is not necessary anymore when using Symfony 2.3+. I added a versionadded note here, but we might decide to remove the obsolete paragraph instead, making the cookbook only about generating urls (which would require renaming the page then)