-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a new entry about reverse proxies in the framework #4102
Conversation
… to it in many places
.. tip:: | ||
|
||
If you're using the Symfony Framework, start by reading | ||
:doc:`/cookbookrequest/load_balancer_reverse_proxy`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing slash between cookbook and request.
Thanks for the fast and thorough checking - I've updated the PR! |
to get information like the client's IP address, host, port and whether or | ||
not the request is using HTTPS. | ||
|
||
But What if the IP of my Reverse Proxy Changes Constantly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lowercased "what"
+1, this will help (cf. symfony/symfony#11595) |
Great writeup @weaverryan! This is exactly what I meant in #2946 |
…rk (weaverryan) This PR was merged into the 2.3 branch. Discussion ---------- Adding a new entry about reverse proxies in the framework Hi guys! | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | all (or 2.3+) | Fixed tickets | #2946 #2491 Per #2491, I wanted to answer the simple question: "What do I need to do in order to configure Symfony if I have a reverse proxy". The `trusted_proxies` is already documented in the reference section, but this is a full walk-through of what you should be doing and why. I've also increased links in several places where notes are needed. Thanks! Commits ------- 5ab6c4a Title case fix thanks to @xabbuh! 89e4d9d A bunch of changes thanks to @xabbuh and @stof 81053ab Fixing build error c55bc2e Adding another note about how AppCache is a reverse proxy at the IP address 127.0.0.1 18af4e8 Adding a new entry about reverse proxies in the framework and linking to it in many places
Yay, merged! Thanks for the feedback! |
static IP address or even a range that you can target with the CIDR notation. | ||
In this case, you'll need to - *very carefully* - trust *all* proxies. | ||
|
||
1. Configure your web server(s) to *not* respond to traffic from *any* clients |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does using 1.
repeatedly actually work? I thought it was #.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right - I'll fix that right now! I think 1.
is Markdown (or I'm just crazy).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think so. I just failed with this as well. It's so intuitive, it really should have been supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like this is not fixed, @weaverryan ? And yes, using multiple 1.
's to define an ordered list is a Markdown feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weaverryan fixed it in 2b1935b.
Hi guys!
Per #2491, I wanted to answer the simple question: "What do I need to do in order to configure Symfony if I have a reverse proxy". The
trusted_proxies
is already documented in the reference section, but this is a full walk-through of what you should be doing and why. I've also increased links in several places where notes are needed.Thanks!