Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Book][Security] constants are defined in the SecurityContextInterface #3779

Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 8, 2014

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

@wouterj
Copy link
Member

wouterj commented Apr 8, 2014

It works both, is there a good reason to use this?

@xabbuh
Copy link
Member Author

xabbuh commented Apr 8, 2014

This is more a change to make clear that those constants don't depend on a concrete SecurityContextInterface implementation. People might get confused and may think that the constants are just part of the implementation shipped with the Security component which is not the case though.

@wouterj
Copy link
Member

wouterj commented Apr 8, 2014

Ah, I see now 👍 (that's why I asked for a good reason :P)

@weaverryan
Copy link
Member

I like it too - good job noticing it!

@weaverryan weaverryan merged commit 4b7c8c2 into symfony:2.3 May 6, 2014
weaverryan added a commit that referenced this pull request May 6, 2014
…xtInterface (xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Book][Security] constants are defined in the SecurityContextInterface

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Commits
-------

4b7c8c2 [Book][Security] constants are defined in the SecurityContextInterface
@xabbuh xabbuh deleted the security-context-interface-constants branch May 6, 2014 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants