Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update collection.rst - add cascade_validation opt #3518

Closed
wants to merge 1 commit into from

Conversation

jillro
Copy link

@jillro jillro commented Jan 28, 2014

Q A
Doc fix? no
New docs? no
Applies to all

It makes sense to describe cascade_validation option in collection
documentation. Valid constraint does not suit all needs, especially
when we have to set validation_groups for embed object/forms, and so
cascade_validation should not be that "hidden".

It makes sense to describe cascade_validation option in collection
documentation. `Valid` constraint does not suit all needs, especially
when we have to set validation_groups for embed object/forms, and so
cascade_validation should not be that "hidden".
@wouterj
Copy link
Member

wouterj commented Jan 28, 2014

👍

This PR is related to issue #2360

@weaverryan weaverryan mentioned this pull request Feb 4, 2014
weaverryan added a commit that referenced this pull request Feb 4, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Rebasing #3518

This is just a rebase of #3518 against the 2.3 branch so that it can be merged cleanly.

Commits
-------

561d201 update collection.rst - add cascade_validation opt
@weaverryan
Copy link
Member

This is a really great change - the exact types of small changes that make a lot of sense and make the docs really great. So thank you Guillaume!

I rebased this against 2.3 (since 2.2 has reached end of life and this patch didn't apply cleanly to 2.3) and opened (and merged) PR #3538.

Thanks!

@weaverryan weaverryan closed this Feb 4, 2014
@jillro jillro deleted the addcascadevalidation branch February 4, 2014 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants