[HttpFoundation] Do not use named parameters in example #20433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Dec 3, 2024
|
@MrYamous actually, the arguments do work and I'd personally love to use that in the examples. But, after discussing internally in the Core Team, we decided to not use named arguments in Symfony Docs and the Symfony Blog. This is because Symfony can change the name of those arguments; they are not covered by the BC Promise. |
javiereguiluz
force-pushed
the
iputils-anonymize
branch
from
919ae47 to
ec2743d
Compare
|
Merged! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed from blog article
The example in the blog seems to me to be the right one, parameters aren't actually implemented so using named paramets is not possible yet