Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed link #17

Conversation

blue-eyes
Copy link
Contributor

No description provided.

@wouterj wouterj mentioned this pull request Oct 6, 2012
fabpot added a commit to fabpot/symfony-docs that referenced this pull request Nov 12, 2014
Commits
-------

11886e6 Merge branch 'master' of https://github.com/amitayh/Create-Your-Framework
a8a2da0 Fixed part 12 typos
26bef8d Fixed typos

Discussion
----------

Fixed minor typos for part 12
weaverryan added a commit that referenced this pull request Jul 2, 2015
…pot, lyrixx, jdreesen, catchamonkey, gnugat, andreia, Arnaud Kleinpeter, willdurand, amitayh, nanocom, hrbonz, Pedro Gimenez, ubick, dirkaholic, bamarni, revollat, javiereguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Integrate the "Create your own framework" tutorial

This is a follow-up of the stalled #4455 PR. I've made most, but not all, of the changes proposed by reviewers.

Specifically, I haven't changed the occurrences of `we` by `you`. The reason is that it's too much work. The original PR (submitted 8 months ago) died for that reason. So here it is my question: could we bypass the `we -> you` changes to merge it as soon as possible and fix that in further pull requests?

Commits
-------

bca9bae Updated doc references in the map.rst.inc file
108f109 Removed the numbers from the file names
db9fa43 Made a lot of improvements suggested by reviewers
126bcef removed external references alignement
13a7170 made some changes to better integrate the tutorial into the current documentation
bf9c871 fixed markup
d44e4a2 added the new tutorial in the main index
73cd243 added the "Create your own framework" tutorial
409dba5 move things around
f303b20 removed versions when adding Symfony component with Composer
55f5c12 updated the whole book (changes mainly related to Composer)
842e4d1 bug #25 Update part06.rst (revollat)
a1336e0 Update part06.rst
d802d42 updated code for Symfony 2.3 and made minor tweaks to the text
f3c151c reworded slightly some sentence to convert the text from a series of articles to a book
ca9d5d8 removed unused references
249b704 added missing links
f6656e4 removed a note that is not relevant anymore
10e2732 added an index file
c88c20a removed usage of the ClassLoader component in favor of Composer
2ddd8b9 merged branch bamarni/master (PR #24)
799e963 updated composer autoload path
91e46f6 removed the paragraph about CS as we now have standards
43e2e35 Merge pull request #23 from dirkaholic/master
6e01599 Fix little typo
e8c19f7 Merge pull request #22 from ubick/master
8e7106d Fixed a typo in part02.rst (<php changed to <?php)
c087780 merged branch amitayh/master (PR #17)
0d6beb1 merged branch pedrotgimenez/part11 (PR #21)
60617d7 Fixed one typo.
aae0705 fixed CS
9533f9a merged branch hrbonz/part12_fixes (PR #19)
d0ff8bc updated titles
400c087 add framework code as people would probably modify it following first code example (putting object creations in src/Simplex/Framework.php)
de69a87 HttpKernel name can't be imported twice, if importing only Symfony\Component\HttpKernel\HttpKernel there will be problems later with HttpKernel subclasses (HttpKernel\Controller\ControllerResolver first and the others following). Could use 'use ... as ...' but I don't like it.
006b1e2 fixed markup
1f43dbf removed conflict merge
0941f47 merged branch Nanocom/master (PR #18)
d907d46 Fixed typos
db59374 fixed typo
11886e6 Merge branch 'master' of https://github.com/amitayh/Create-Your-Framework
a8a2da0 Fixed part 12 typos
26bef8d Fixed typos
9bc692f added part 12
0b7581d merged branch willdurand/patch-1 (PR #16)
16b5b09 Fixed typo
831adec merged branch Nanocom/master (PR #15)
a3f0b31 Corrected few typos
ae1171a merged branch jdreesen/patch-3 (PR #10)
7a8e449 merged branch Nanocom/master (PR #14)
09969d9 added part 11
76e45f9 fixed markup
fda9900 fixed pygments code name for json
02aab54 Corrected some english errors
8399581 moved the Context::fromRequest() code to the Framework class
111cac0 removed some use statement to be more consistent with previous parts
a635d89 added part 10
bde64c8 made small tweaks
54e1b08 added a note in part 8
f00401d added part 8
5674395 renamed part as we now know that we are going to have more than 10 parts
479a85e fixed typos
a0b1d42 merged branch gnugat/part7-typo-simple (PR #12)
9ffd186 [part7] Fixing typo: adding 'x' to Simple/Framework class
97743fb added part 7
fdb195c added part 6
0ce2a83 fixed some typos
db0ad14 added part 5
bd3ca8e fixed extract() calls
7e8da09 fixed typo (closes #8)
1473eec fixed typo
358b4c8 added part 4
255577f went back to 2.1.* in composer.json files
3d46b1d merged branch jdreesen/patch-2 (PR #7)
a18f827 fixed typos
18d376e updated composer.json
26be81c added part 3
4b39fc0 removed the path to composer.json as JSON doe snot support comments but some people copy/paste this line too
00e524e fixed ambiguity (closes #6)
6fe23c0 merged branch andreia/master (PR #5)
95edc8d Add missing colon to code-block
7e5cd41 merged branch gnugat/part2-typo-where-where (PR #4)
4c2e4f9 [part2] Fixinng typo: removing one of the double where
ee67eee fixed markup
94db3cb merged branch catchamonkey/patch-1 (PR #3)
a4f52d9 added links to projects
fcaf268 Fixes grammatical error
2c79d42 added part 2
13ba87c added a tip about the Composer autoloader
b93c118 merged branch jdreesen/patch-1 (PR #2)
269c6ce merged branch lyrixx/patch-1 (PR #1)
b239305 Fixed typo
8ed4076 Fixed typo
99c5c08 added a LICENSE file
0ef3f8e added part 1
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant