Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated composer install instructions #6555

Closed
theofidry opened this issue May 9, 2016 · 6 comments
Closed

Outdated composer install instructions #6555

theofidry opened this issue May 9, 2016 · 6 comments
Labels
actionable Clear and specific issues ready for anyone to take them. bug good first issue Ideal for your first contribution! (some Symfony experience may be required) Hack Day hasPR A Pull Request has already been submitted for this issue.

Comments

@theofidry
Copy link
Contributor

The install instructions still refers to use the curl command, which has been removed in favour of the installer for various reasons.

What do you want to do? Update this page or just link to Composer install instructions?
@xabbuh
Copy link
Member

xabbuh commented May 9, 2016

I think we should remove the existing document from the table of contents. Then we should update all links to it to point to the installation instructions on getcomposer.org and only keep the existing one to maintain existing deep links from other third-party pages (we could update it to directly link to the subsections of the Composer installation documentation).

@wouterj
Copy link
Member

wouterj commented May 14, 2016

We've written the article because the composer install docs still do not suggest a global installation by default. Unless that's fixed, we should keep the current doc imo.

@javiereguiluz
Copy link
Member

I agree with Wouter.

@celdia
Copy link

celdia commented May 20, 2016

We should keep this doc I think. Because we could need curl for others purposes or PHP projects.

@wouterj wouterj added bug good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. Hack Day and removed needs comments labels May 20, 2016
@xabbuh
Copy link
Member

xabbuh commented May 21, 2016

@wouterj is right about the reason why we added the article in the past. So we should indeed update it.

@snoek09
Copy link

snoek09 commented May 21, 2016

I'll update the instructions.

@snoek09 snoek09 mentioned this issue May 21, 2016
Closed
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label May 21, 2016
xabbuh added a commit that referenced this issue May 21, 2016
@xabbuh
minor #6585 6555 link to Download instructions page & Windows executa…
ed51bdc 
…ble (snoek09)

This PR was squashed before being merged into the 2.3 branch (closes #6585).

Discussion
----------

6555 link to Download instructions page & Windows executable

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #6555

I decided to not copy any instructions as mentioned on https://getcomposer.org/download/

> WARNING: Please do not redistribute the install code. It will change with every version of the installer. Instead, please link to this page.

Commits
-------

1967b9d 6555 link to Download instructions page & Windows executable
@xabbuh xabbuh closed this as completed May 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. bug good first issue Ideal for your first contribution! (some Symfony experience may be required) Hack Day hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@javiereguiluz @snoek09 @wouterj @xabbuh @theofidry @celdia