Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form] order of options in choice types references #6261

Closed
HeahDude opened this issue Feb 11, 2016 · 3 comments
Closed

[Form] order of options in choice types references #6261

HeahDude opened this issue Feb 11, 2016 · 3 comments
Labels
actionable Clear and specific issues ready for anyone to take them. Form good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.

Comments

@HeahDude
Copy link
Contributor

It seems to be a convention to use an alphabetical order for options in field type references.

But things got a little messy in choice types as of 2.7.

Concerning EntityType I could fix that in #6260 or we should wait for it to be merged before applying a global fix for this issue.

@wouterj @xabbuh WDTH ?
@HeahDude HeahDude mentioned this issue Feb 11, 2016
Merged
@xabbuh xabbuh added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. Form hasPR A Pull Request has already been submitted for this issue. labels Feb 11, 2016
@xabbuh
Copy link
Member

xabbuh commented Feb 11, 2016

That's a good idea. We deliberately ordered the options alphabetically some time ago and I think we should maintain that.

@HeahDude
Copy link
Contributor Author

Agreed. What about EntityType ? I guess it would avoid conflicts if changes are done in #6260, WDYT ?

xabbuh added a commit that referenced this issue Feb 12, 2016
@xabbuh
minor #6262 [Form] reorder options in choice types references (HeahDude)
bc70d00 
This PR was merged into the 2.7 branch.

Discussion
----------

[Form] reorder options in choice types references

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.7+
| Fixed tickets | #6261

Commits
-------

3eda649 reorder options in choice types references
@xabbuh
Copy link
Member

xabbuh commented Feb 12, 2016

@HeahDude The entity type options are already not sorted in the 2.3 docs. I would start reordering them there.

@wouterj wouterj closed this as completed Mar 5, 2016
@HeahDude HeahDude mentioned this issue Mar 6, 2016
Merged
wouterj added a commit that referenced this issue Mar 8, 2016
@wouterj
minor #6330 [Form] reorder EntityType options (HeahDude)
a99cc60 
This PR was merged into the 2.7 branch.

Discussion
----------

[Form] reorder EntityType options

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.7+
| Fixed tickets | #6261 (rest)

Commits
-------

30a1495 [Form] reorder EntityType options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. Form good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wouterj @xabbuh @HeahDude