Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traditional Login Form does not need http_basic: configuration #5763

Closed
JVerstry opened this issue Oct 7, 2015 · 2 comments
Closed

Traditional Login Form does not need http_basic: configuration #5763

JVerstry opened this issue Oct 7, 2015 · 2 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Security

Comments

@JVerstry
Copy link

JVerstry commented Oct 7, 2015

This is more like cherry on the cake rather than a fundamental issue, but the documentation available at: http://symfony.com/doc/current/cookbook/security/form_login_setup.html about creating a traditional login form seems to imply that http_basic: configuration is required.

My initial thought was it should not be required since a login form typically replaces basic http authentication. But, since I am not a Symfony2 expert, I asked a question on Stackoverflow at http://stackoverflow.com/questions/32990643/symfony2-is-basic-authentication-configuration-required-for-traditional-login/32990667#32990667 and someone confirmed that it is not required.

I believe we should mention this in the documentation for the sake of clarity.

@xabbuh xabbuh added the Security label Oct 7, 2015
@xabbuh
Copy link
Member

xabbuh commented Oct 7, 2015

Yes, I think you are right. I don't know how this slipped in, but I think we should simply remove it from the documentation.

@javiereguiluz
Copy link
Member

This error probably originated because the article is a follo up of the security introduction. That's why you can read this phrase at the beginning:

This chapter assumes that you've followed the beginning of the security chapter and have http_basic authentication working properly.

In any case, thanks @JVerstry for reporting this issue. A pull request to fix it is ready at #5768.

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Oct 8, 2015
weaverryan added a commit that referenced this issue Nov 20, 2015
…aviereguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Removed "http_basic" config from the login form cookbook

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #5763

Commits
-------

d019f83 Removed an outdate paragraph
f73133d Removed "http_basic" config from the login form cookbook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hasPR A Pull Request has already been submitted for this issue. Security
Projects
None yet
Development

No branches or pull requests

4 participants