Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the range type #5439

Closed
xabbuh opened this issue Jun 25, 2015 · 1 comment
Closed

Document the range type #5439

xabbuh opened this issue Jun 25, 2015 · 1 comment
Labels
actionable Clear and specific issues ready for anyone to take them. Form good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Milestone
2.8

Comments

@xabbuh
Copy link
Member

xabbuh commented Jun 25, 2015

symfony/symfony#12067 added a new range type.
@xabbuh xabbuh added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. Form labels Jun 25, 2015
@xabbuh xabbuh added this to the 2.8 milestone Jun 25, 2015
@harikt harikt mentioned this issue Jun 28, 2015
Merged
@harikt
Copy link
Contributor

harikt commented Jun 28, 2015

@xabbuh may be label has PR ?

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Jun 28, 2015
weaverryan added a commit that referenced this issue Jul 16, 2015
@weaverryan
feature #5458 HTML5 range documentation (harikt)
f4b7d7f 
This PR was merged into the 2.8 branch.

Discussion
----------

HTML5 range documentation

Hi,

| Q                      | A
| ------------- | ---
| Doc fix?            | yes
| New feature?   | yes
| BC breaks?      | no
| Deprecations? | no
| Fixed tickets    | [#5439]
| Code PR      | [12607]
| License       | MIT

I am trying to contribute to range added for the PR symfony/symfony#12067 & symfony/symfony#11979 which fixes #5439 .

Need some help on moving for I am really new to the documentation.

The current issues I feel is whether we need to add Basic usage or is that only reference ?

I had a look at http://symfony.com/doc/current/reference/forms/types/number.html which would have been similar, but that seems it referencing to choice seems more confusing.

I have looked into other types also and almost all are some what similar.

Any input is highly appreciated and will work on in the free time. If someone is interested please do take the PR or finish it .

Thank you.

Commits
-------

2863079 Fix moving the mapped down as per @xabbuh
abf3e8e Fix the rendering issue
3c6ff76 Fix issues reported by @snoek09 . Thank you.
a2c3f21 Make the necessary changes mentioned by @xabbuh and add example for form
d4d1f12 Starting with range documentation
@wouterj wouterj mentioned this issue Aug 21, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. Form good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
2.8
Development

No branches or pull requests
3 participants
@harikt @weaverryan @xabbuh