Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for Asset Packages #4439

Closed
ghost opened this issue Nov 10, 2014 · 5 comments
Closed

Documentation for Asset Packages #4439

ghost opened this issue Nov 10, 2014 · 5 comments
Labels
hasPR A Pull Request has already been submitted for this issue.

Comments

@ghost
Copy link

ghost commented Nov 10, 2014

Currently Asset Packages are only documented in the Framework Full Default Configuration Reference

It would be nice to have a little more Documentation about this Feature because it's quiet usefull.

I think the important PRs are:
@wouterj
Copy link
Member

wouterj commented Jan 2, 2015

@LangJ I've included some more information in the config in https://github.com/symfony/symfony-docs/pull/4736/files#diff-c0c158a40398b72fa4f0c9d0accbc169R1085 Do you think this is enough?

@wouterj wouterj mentioned this issue Jan 2, 2015
Closed
@ghost
Copy link
Author

ghost commented Jan 5, 2015

Yes, it looks good. Thank you.

@javiereguiluz
Copy link
Member

This issue can be closed because the issue reporter is happy with the improvements made by @wouterj. Moreover, asset packages will be soon better explained in the soon-to-be-merged Asset component documentation (see #4987).

@wouterj
Copy link
Member

wouterj commented Feb 19, 2015

@javiereguiluz both PRs aren't merged yet. According to our conventions, we'll leave this one open until they are merged.

@wouterj wouterj added the hasPR A Pull Request has already been submitted for this issue. label May 2, 2015
@wouterj wouterj mentioned this issue May 23, 2015
Merged
wouterj added a commit that referenced this issue May 24, 2015
@wouterj
feature #5298 Completed framework config (WouterJ)
7c1507c 
This PR was merged into the 2.3 branch.

Discussion
----------

Completed framework config

This PR only changes and adds new configuration, without moving all things around. This will things a lot easier to diff and see where things have gone wrong. I'll thouroughly review this PR and merge then.

Replaces #4736

| Q | A
| --- | ---
| Doc fix? | yes
| New docs? | yes
| Applies to | 2.3+
| Fixed tickets | #4439, #3586

Commits
-------

54e8b0a Let docbot review reference
f223643 Apply some of Ryan's suggestions
7e45e8f Completed framework config reference
@wouterj
Copy link
Member

wouterj commented May 24, 2015

Both PRs are merged now

@wouterj wouterj closed this as completed May 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@javiereguiluz @wouterj