Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Components][Security] Taking the Security component split into account #4151

Closed
xabbuh opened this issue Aug 20, 2014 · 2 comments
Closed

[Components][Security] Taking the Security component split into account #4151

xabbuh opened this issue Aug 20, 2014 · 2 comments
Labels
actionable Clear and specific issues ready for anyone to take them. Security
Milestone
2.4

Comments

@xabbuh
Copy link
Member

xabbuh commented Aug 20, 2014

Starting with Symfony 2.4, the Security component has been split into four packages: symfony/security-acl, symfony/security-core, symfony/security-csrf and symfony/security-http. This should be documented in some way at least in the components documentation.
@xabbuh xabbuh mentioned this issue Aug 20, 2014
Merged
@xabbuh xabbuh added actionable Clear and specific issues ready for anyone to take them. Security labels Oct 11, 2014
@xabbuh xabbuh added this to the 2.4 milestone Oct 11, 2014
@javiereguiluz javiereguiluz mentioned this issue Jun 24, 2015
Closed
wouterj added a commit that referenced this issue Jun 26, 2015
@wouterj
feature #5435 Added information about the four sub-components of Secu…
e141c87 
…rity component (javiereguiluz)

This PR was squashed before being merged into the 2.6 branch (closes #5435).

Discussion
----------

Added information about the four sub-components of Security component

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | 2.6+
| Fixed tickets | #4151

Commits
-------

839342d Added information about the four sub-components of Security component
@javiereguiluz
Copy link
Member

This issue was supossedly fixed by #5435. I don't know if you still consider it unfixed or if there was some error with the tool that closes issues when merging pull requests. Thanks.

@wouterj wouterj closed this as completed Jun 26, 2015
@wouterj
Copy link
Member

wouterj commented Jun 26, 2015

As the PR was merged with a squash, the commit was not a proper merge commit. This means that GitHub will only close the issues after "closes" in the commit message once the commit was merged into the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. Security
Projects
None yet
Milestone
2.4
Development

No branches or pull requests
3 participants
@javiereguiluz @wouterj @xabbuh