Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Callback] Missing information about payload in callback #18787

Closed
PrOF-kk opened this issue Aug 25, 2023 · 1 comment
Closed

[Callback] Missing information about payload in callback #18787

PrOF-kk opened this issue Aug 25, 2023 · 1 comment
Labels
hasPR A Pull Request has already been submitted for this issue. Validator

Comments

@PrOF-kk
Copy link
Contributor

PrOF-kk commented Aug 25, 2023

Currently the documentation states that the only parameters passed to the callback are the validated object (if callback is not concete) and the ExecutionContextInterface.
However since symfony/symfony#16909 the payload is passed as well.
The examples show this correctly (added with #6593) but the description does not
@alamirault alamirault mentioned this issue Aug 27, 2023
Merged
javiereguiluz added a commit that referenced this issue Aug 28, 2023
@javiereguiluz
minor #18791 [Validator] Missing information about payload in callbac…
111e861 
…k (alamirault)

This PR was merged into the 5.4 branch.

Discussion
----------

[Validator] Missing information about payload in callback

Fix #18787

Commits
-------

ab647bf Missing information about payload in callback
@javiereguiluz
Copy link
Member

Fixed in #18791.

@xabbuh xabbuh added Validator hasPR A Pull Request has already been submitted for this issue. labels Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Validator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javiereguiluz @xabbuh @PrOF-kk