Skip to content

Commit

Permalink
Merge branch '2.7'
Browse files Browse the repository at this point in the history
* 2.7:
  Removing micro-optimization note about @template
  • Loading branch information
weaverryan committed Mar 15, 2015
2 parents f24c84f + 3abbf0b commit 3fb0d42
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions best_practices/controllers.rst
Original file line number Diff line number Diff line change
Expand Up @@ -76,20 +76,15 @@ Template Configuration
Don't use the ``@Template()`` annotation to configure the template used by
the controller.

The ``@Template`` annotation is useful, but also involves some magic. For
that reason, we don't recommend using it.
The ``@Template`` annotation is useful, but also involves some magic. We
don't think its benefit is worth the magic, and so recommend against using
it.

Most of the time, ``@Template`` is used without any parameters, which makes
it more difficult to know which template is being rendered. It also makes
it less obvious to beginners that a controller should always return a Response
object (unless you're using a view layer).

Lastly, the ``@Template`` annotation uses a ``TemplateListener`` class that hooks
into the ``kernel.view`` event dispatched by the framework. This listener introduces
a measurable performance impact. In the sample blog application, rendering the
homepage took 5 milliseconds using the ``$this->render()`` method and 26 milliseconds
using the ``@Template`` annotation.

How the Controller Looks
------------------------

Expand Down

0 comments on commit 3fb0d42

Please sign in to comment.