Skip to content

Commit

Permalink
minor #57307 [SecurityBundle] Adds space in FirewallTraits error me…
Browse files Browse the repository at this point in the history
…ssage (mvhirsch)

This PR was merged into the 5.4 branch.

Discussion
----------

[SecurityBundle] Adds space in `FirewallTrait`s error message

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Issues        |
| License       | MIT

I just hit that error while debugging my application. I wondered why it was written like this:

```
[...] found for this firewall.Did you forget to add a [...]
```

Note that missing whitespace after dot.

I'm sorry for being picky, but it hurt my eyes 🙈

Commits
-------

87b4904ba7 add space in error message
  • Loading branch information
fabpot committed Jun 7, 2024
2 parents d977faa + 22157c5 commit 2af1350
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Security/FirewallAwareTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ private function getForFirewall(): object
if (!$this->locator->has($firewallName)) {
$message = 'No '.$serviceIdentifier.' found for this firewall.';
if (\defined(static::class.'::FIREWALL_OPTION')) {
$message .= sprintf('Did you forget to add a "'.static::FIREWALL_OPTION.'" key under your "%s" firewall?', $firewallName);
$message .= sprintf(' Did you forget to add a "'.static::FIREWALL_OPTION.'" key under your "%s" firewall?', $firewallName);
}

throw new \LogicException($message);
Expand Down

0 comments on commit 2af1350

Please sign in to comment.