-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with Doctrine DBAL 3 #69
Conversation
61fe3c7
to
f98578f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @derrabus for modernizing this library a bit!
However, it seems like we're not running a lowest dep test in the CI. Running it locally, I get 6 errors like this:
Error: Call to undefined method Doctrine\DBAL\Statement::executeStatement()
/home/wouter/projects/github.com/symfony/security-acl/Tests/Dbal/AclProviderTest.php:158
Should we raise the lowest dep for DBAL?
@wouterj What version of DBAL did you test with? |
@derrabus I checked out this branch locally and ran:
|
Seems like the forward compatibility layer of DBAL 2.13.0 was incomplete. That method does not exist in DBAL 3.0 either, so I've bumped to |
Thanks @derrabus. |
"doctrine/dbal": "^2.13", | ||
"doctrine/common": "^2.2|^3", | ||
"doctrine/persistence": "^1.3.3|^2", | ||
"doctrine/dbal": "^2.13.1|^3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conflict rule needs to be updated
This PR was merged into the 3.x-dev branch. Discussion ---------- Fix DBAL conflict rule Fixes #69 (comment) Commits ------- 0bac3d7 Fix DBAL conflict rule
No description provided.