Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Doctrine DBAL 3 #69

Merged
merged 1 commit into from
Apr 24, 2021

Conversation

derrabus
Copy link
Member

No description provided.

@derrabus derrabus force-pushed the bugfix/dbal3 branch 2 times, most recently from 61fe3c7 to f98578f Compare April 23, 2021 19:27
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @derrabus for modernizing this library a bit!

However, it seems like we're not running a lowest dep test in the CI. Running it locally, I get 6 errors like this:

Error: Call to undefined method Doctrine\DBAL\Statement::executeStatement()

/home/wouter/projects/github.com/symfony/security-acl/Tests/Dbal/AclProviderTest.php:158

Should we raise the lowest dep for DBAL?

@derrabus
Copy link
Member Author

@wouterj What version of DBAL did you test with?

@wouterj
Copy link
Member

wouterj commented Apr 24, 2021

@derrabus I checked out this branch locally and ran:

§ sf composer update --prefer-lowest
Loading composer repositories with package information
Updating dependencies
Lock file operations: 16 installs, 0 updates, 0 removals
  - Locking doctrine/annotations (v1.0)
  - Locking doctrine/cache (v1.0)
  - Locking doctrine/collections (v1.0)
  - Locking doctrine/common (2.13.1)
  - Locking doctrine/dbal (2.13.0)
  - Locking doctrine/deprecations (v0.5.3)
  - Locking doctrine/event-manager (1.1.1)
  - Locking doctrine/inflector (v1.0)
  - Locking doctrine/lexer (v1.0)
  - Locking doctrine/persistence (1.3.8)
  - Locking doctrine/reflection (1.2.2)
  - Locking psr/log (1.0.0)
  - Locking symfony/phpunit-bridge (v5.2.0)
  - Locking symfony/polyfill-php56 (v1.0.0)
  - Locking symfony/polyfill-util (v1.0.0)
  - Locking symfony/security-core (v3.4.0)
Writing lock file
Installing dependencies from lock file (including require-dev)
...

@derrabus
Copy link
Member Author

Seems like the forward compatibility layer of DBAL 2.13.0 was incomplete. That method does not exist in DBAL 3.0 either, so I've bumped to ^2.13.1|^3.1 now. Good catch, @wouterj!

@wouterj
Copy link
Member

wouterj commented Apr 24, 2021

Thanks @derrabus.

@wouterj wouterj merged commit cf12636 into symfony:main Apr 24, 2021
@derrabus derrabus deleted the bugfix/dbal3 branch April 24, 2021 15:28
"doctrine/dbal": "^2.13",
"doctrine/common": "^2.2|^3",
"doctrine/persistence": "^1.3.3|^2",
"doctrine/dbal": "^2.13.1|^3.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conflict rule needs to be updated

@derrabus derrabus mentioned this pull request Apr 28, 2021
derrabus added a commit that referenced this pull request Apr 28, 2021
This PR was merged into the 3.x-dev branch.

Discussion
----------

Fix DBAL conflict rule

Fixes #69 (comment)

Commits
-------

0bac3d7 Fix DBAL conflict rule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants