Fix symfony 5.3 security incompatiblity

[acrobat]

Follow up of #100

The AuthenticationTrustResolverInterface::isAuthenticated method was only added in symfony 5.4 but the AuthenticatedVoter::PUBLIC_ACCESS constant was already available in symfony 5.3, this causes an error when using security-acl 3.3.0 with symfony 5.3.x

security-acl/Domain/SecurityIdentityRetrievalStrategy.php

Lines 81 to 83 in 04d6fad

	if (\defined('\Symfony\Component\Security\Core\Authorization\Voter\AuthenticatedVoter::PUBLIC_ACCESS')) {
	return !$this->authenticationTrustResolver->isAuthenticated($token);
	}

The first commit actually refactors the test case because even when executing the tests on symfony 5.3 they still pass as we mocked that class/method. I've also changed some things in the github ci workflow because I wasn't able to get symfony 5.3 dependencies with the ramsey/composer-install packages (lowest = install, highest = update but this would cause dev packages in this setup), so I'm not sure if this is the desired setup. Let me know if I need the change anything.

The second commit actually fixes the problem (the first commit shows a failing test on symfony 5.3 first)

[derrabus]

Do you really need this fix? That's an incredibly complex test setup for an EOL Symfony branch. 😕

[acrobat]

Hmm yes, I thought 5.3 was still supported but you are right as this was also my feeling that the workflow got more complex. Maybe revert the workflow change but keep the test changes and code fix so the library is compatible? Or bump the version constraint for 3.3.x to `symfony/security-core: "^4.4|^5.4|^6.0"?

[derrabus]

I'd be in favor of only merging the second commit and tag a release, if @wouterj agrees. For 3.4 we should make the bump you've suggested.

[acrobat]

@derrabus That works for me! I've updated the PR to only include the last commit with the fix. The other can still be viewed here -> acrobat@50f1abe

[wouterj]

(I'm not close to a laptop this week, change is OK by me and if @derrabus can do a release afterwards that would be great 😃)

[derrabus]

Thank you @acrobat.

[derrabus]

https://github.com/symfony/security-acl/releases/tag/v3.3.1