Oracle add duplicate slashes for ClassType of ObjectIdentity in ACL provider

[soyuka]

symfony/symfony#15723 follow up

Indeed, when $this->connection->quote is used on the classType, Oracle adds two back-slashes.

I've found a simple fix that is to stripcslashes($classType) on hydrateObjectIdentities. But this should only apply when the $classType contains more than one \.

Thoughts?

[derrabus]

@soyuka If you're still around (2015, wow), can you have a look at #96?

[soyuka]

Hi @derrabus, yes around but not using Oracle anymore the fix looks alright though :)

[FaritSlv]

Hi @derrabus, will you accept the PR? :)

[derrabus]

It looks good, but I don't have a setup to verify it. 🤔

[FaritSlv]

@derrabus
Here is the docker image of OracleDB that I am using
container-registry.oracle.com/database/express:latest

The rest is standard.

[FaritSlv]

@derrabus
Hi, is there anything required of me to accept a PR?

[derrabus]

My main issue is that we don't have a maintainer with Oracle knowledge or a CI that runs tests against Oracle on this repo. I don't feel like I'm the right person to merge this.

[FaritSlv]

Hi @derrabus
If I write tests and CI for Oracle DB it will somehow help?

[wouterj]

It would be great if we can refactor https://github.com/symfony/security-acl/blob/main/Tests/Dbal/AclProviderTest.php to test on Oracle, MySQL and sqlite (current) on GitHub actions (and skip the particular database if any of them is not supported locally).

That would give us much more confidence that the fix works and we're not breaking it in the future.

[soyuka]

testing on oracle is really hard as you need EULA to be accepted before running their dev tools ask @greg0ire I think he managed to but not sure he took much more time

in the meantime @FaritSlv just override the class locally.

[greg0ire]

I tried to do so on the ORM, since we already do have Oracle test on the DBAL. My attempt can be seen at doctrine/orm#8958

[wouterj]

Hmm, that's a bit of a bummer...

In that case, we rely on the community. Currently, #96 is open without any reviewers. If anyone that has Oracle locally can verify this indeed fixes this annoying bug, I would be much more confident when merging the PR.

[soyuka]

Not using Oracle anymore but the bug in 2015 was there and the fix I proposed was the same as the one in #96 I'd be 👍 to merge it.