Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added monolog in test env #329

Merged
1 commit merged into from
Dec 27, 2017
Merged

Added monolog in test env #329

1 commit merged into from
Dec 27, 2017

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Dec 27, 2017

Q A
License MIT

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

handlers:
main:
type: stream
path: "%kernel.logs_dir%/%kernel.environment%.log"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why don't we hardocde the "test.log" filename ? (same in other env)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot come up with a good reason. The result would be the same...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, indeed ;)

@ghost ghost merged commit 6743e62 into master Dec 27, 2017
ghost pushed a commit that referenced this pull request Dec 27, 2017
@lyrixx lyrixx deleted the monolog-in-dev branch December 27, 2017 23:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants