Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add a hint on where to add the db server version #267

Closed
wants to merge 1 commit into from
Closed

[WIP] Add a hint on where to add the db server version #267

wants to merge 1 commit into from

Conversation

goetas
Copy link
Contributor

@goetas goetas commented Nov 20, 2017 •
edited
Loading

Q A
License MIT

This is just a RFC, not sure if is the best way to solve the symfony/symfony#24927 issue.
related also to symfony/symfony#25010 (comment)

ghost
ghost approved these changes Nov 20, 2017
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Nov 20, 2017
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@weaverryan
Copy link
Member

See #258, where I suggest the same thing (happy to see we are thinking alike!)

@goetas
Copy link
Contributor Author

goetas commented Nov 20, 2017

yay!

@goetas goetas closed this Nov 20, 2017
@goetas goetas deleted the patch-1 branch November 20, 2017 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goetas @weaverryan