-
-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always set Doctrine server version & platform #258
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f446c92
Moving server_version to committed config
weaverryan 61ca864
adding fallback DATABASE_URL to avoid connecting to the db during
weaverryan 25e9678
Moving some params
weaverryan cb9f0ed
Simplifying setup: don't use any parameters
weaverryan 72bf213
Also putting charset option in a place where it is committed
weaverryan 2d19e7c
Tweak
weaverryan 2efa651
add note to configure doctrine.yaml
weaverryan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
doctrine/doctrine-bundle/1.6/config/packages/doctrine.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ | |
"env": { | ||
"#1": "Format described at http://docs.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/configuration.html#connecting-using-a-url", | ||
"#2": "For an SQLite database, use: \"sqlite:///%kernel.project_dir%/var/data.db\"", | ||
"#3": "Set \"serverVersion\" to your server version to avoid edge-case exceptions and extra database calls", | ||
"DATABASE_URL": "mysql://db_user:[email protected]:3306/db_name?charset=utf8mb4&serverVersion=5.7" | ||
"#3": "Configure your db driver and server_version in config/packages/doctrine.yaml", | ||
"DATABASE_URL": "mysql://db_user:[email protected]:3306/db_name" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<bg=blue;fg=white> </> | ||
<bg=blue;fg=white> Next: Configuration </> | ||
<bg=blue;fg=white> </> | ||
|
||
* Modify your DATABASE_URL config in <fg=green>.env</> | ||
|
||
* Configure the <fg=green>driver</> (mysql) and | ||
<fg=green>server_version</fg> (5.7) in <fg=green>config/packages/doctrine.yaml</> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"parameters" should be defined via the "container" configurator instead