[doctrine-bundle] Docker support #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symfony-bot
suggested changes
Jul 12, 2017
This was referenced May 28, 2018
dunglas
force-pushed
the
doctrine_docker
branch
from
b972369 to
656dae4
Compare
ghost
suggested changes
Apr 27, 2019
dunglas
force-pushed
the
doctrine_docker
branch
from
656dae4 to
383323b
Compare
ghost
suggested changes
Apr 27, 2019
dunglas
force-pushed
the
doctrine_docker
branch
from
383323b to
8bb980d
Compare
ghost
suggested changes
Apr 27, 2019
ghost
deployed
to
dunglas
force-pushed
the
doctrine_docker
branch
4 times, most recently
from
7696ade to
60e907a
Compare
Pierstoval
reviewed
Apr 28, 2019
fabpot
requested changes
May 14, 2019
|
Anyone willing to finish this one? |
|
@fabpot I can take care of it if it's OK for everyone |
|
I'm on it @maxhelias |
dunglas
force-pushed
the
doctrine_docker
branch
from
60e907a to
9e0340f
Compare
maxhelias
reviewed
Aug 3, 2019
| @@ -10,6 +10,26 @@ | |||
| "#1": "Format described at https://www.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/configuration.html#connecting-using-a-url", | |||
| "#2": "For an SQLite database, use: \"sqlite:///%kernel.project_dir%/var/data.db\"", | |||
| "#3": "Configure your db driver and server_version in config/packages/doctrine.yaml", | |||
| "DATABASE_URL": "mysql://db_user:[email protected]:3306/db_name" | |||
| "DATABASE_URL": "mysql://symfony:password@db:3306/symfony?charset=utf8mb4&serverVersion=5.7" | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
fabpot
requested changes
Aug 4, 2019
|
I switched to Postgres in the last commit. |
nicolas-grekas
previously approved these changes
Oct 21, 2020
dunglas
force-pushed
the
doctrine_docker
branch
from
3438fca to
938aca6
Compare
fabpot
reviewed
Nov 9, 2020
fabpot
reviewed
Nov 12, 2020
fabpot
reviewed
Nov 12, 2020
ghost
suggested changes
Nov 12, 2020
fabpot
force-pushed
the
doctrine_docker
branch
from
938aca6 to
1951e0b
Compare
ghost
suggested changes
Nov 17, 2020
fabpot
approved these changes
Nov 17, 2020
chalasr
approved these changes
Nov 17, 2020
pyrech
reviewed
Nov 17, 2020
| }, | ||
| "docker-compose.override.yml": { | ||
| "services": [ | ||
| "db:", |
There was a problem hiding this comment.
Shouldn't this service be named database too?
There was a problem hiding this comment.
correct :) Up for a PR @pyrech?
| "docker-compose.yml": { | ||
| "services": [ | ||
| "database:", | ||
| " image: postgres:${POSTGRES_VERSION:-13}-alpine", |
There was a problem hiding this comment.
@dunglas Not sure if I did already ask this 🙈 , but was there a specific reasons why this yaml files are instead of 4 spaces 2 spaces. And so are not similar to symfony config files?
Make it harder in handling .editorconfig files.
There was a problem hiding this comment.
4 spaces are the way to go indeed.
There was a problem hiding this comment.
Here we go: #1018 :)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires dunglas/symfony-docker#5 and symfony/flex#128.